Attention is currently required from: Arthur Heymans, Eric Lai, Jeff Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nill Ge, Subrata Banik, lichenchen.carl, niehaitao@bytedance.com.
TangYiwei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75736?usp=email )
Change subject: src/arch/x86/smbios.c: Change smbios_fill_dimm_serial_number function to weak
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
This is SMBIOS spec. […]
I know you mean the definition in SPD spec. But it seems that most dimms use SPD Bytes 512~520 to form the serial number on their dimm label. It's not our own format. We can't change the serial number on the dimm label. Please correct me, if I've misunderstood the serial number definition.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75736?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc28a56a577f98a2974407175783e32a1e234f86
Gerrit-Change-Number: 75736
Gerrit-PatchSet: 1
Gerrit-Owner: TangYiwei
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jeff Li
lijinfeng01@inspur.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-Reviewer: niehaitao@bytedance.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: niehaitao@bytedance.com
Gerrit-Attention: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Jeff Li
lijinfeng01@inspur.com
Gerrit-Comment-Date: Thu, 15 Jun 2023 06:47:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Comment-In-Reply-To: TangYiwei
Gerrit-MessageType: comment