HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44828 )
Change subject: mb/google: Use 'PCI_*' macros instead of magic number ......................................................................
mb/google: Use 'PCI_*' macros instead of magic number
Change-Id: I55b7c3d895e560a0716415001a2d9e8c4d69ca7b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/auron/variants/buddy/variant.c M src/mainboard/google/beltino/lan.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/rambi/variants/ninja/lan.c M src/mainboard/google/rambi/variants/sumo/lan.c 5 files changed, 10 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/44828/1
diff --git a/src/mainboard/google/auron/variants/buddy/variant.c b/src/mainboard/google/auron/variants/buddy/variant.c index 81bb828..7213e31 100644 --- a/src/mainboard/google/auron/variants/buddy/variant.c +++ b/src/mainboard/google/auron/variants/buddy/variant.c @@ -4,6 +4,7 @@ #include <fmap.h> #include <types.h> #include <arch/io.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> @@ -163,7 +164,7 @@ ethernet_dev = dev_find_device(BUDDY_NIC_VENDOR_ID, BUDDY_NIC_DEVICE_ID, 0); if (ethernet_dev != NULL) { - io_base = pci_read_config16(ethernet_dev, 0x10) & 0xfffe; + io_base = pci_read_config16(ethernet_dev, PCI_BASE_ADDRESS_0) & 0xfffe;
/* * Battery life time - LAN PCIe should enter ASPM L1 to save diff --git a/src/mainboard/google/beltino/lan.c b/src/mainboard/google/beltino/lan.c index c14a1e4..72686ac 100644 --- a/src/mainboard/google/beltino/lan.c +++ b/src/mainboard/google/beltino/lan.c @@ -3,6 +3,7 @@ #include <cbfs.h> #include <types.h> #include <arch/io.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> @@ -144,7 +145,7 @@ ethernet_dev = dev_find_device(NIC_VENDOR_ID, NIC_DEVICE_ID, 0); if (ethernet_dev != NULL) { - io_base = pci_read_config16(ethernet_dev, 0x10) & 0xfffe; + io_base = pci_read_config16(ethernet_dev, PCI_BASE_ADDRESS_0) & 0xfffe;
/* * Battery life time - LAN PCIe should enter ASPM L1 to save diff --git a/src/mainboard/google/butterfly/mainboard.c b/src/mainboard/google/butterfly/mainboard.c index fc38136..8ba47dd 100644 --- a/src/mainboard/google/butterfly/mainboard.c +++ b/src/mainboard/google/butterfly/mainboard.c @@ -3,6 +3,7 @@ #include <types.h> #include <cbfs.h> #include <device/device.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include <console/console.h> #include <drivers/intel/gma/int15.h> @@ -201,7 +202,7 @@ ethernet_dev = dev_find_device(BUTTERFLY_NIC_VENDOR_ID, BUTTERFLY_NIC_DEVICE_ID, dev); if (ethernet_dev != NULL) { - io_base = pci_read_config16(ethernet_dev, 0x10) & 0xfffe; + io_base = pci_read_config16(ethernet_dev, PCI_BASE_ADDRESS_0) & 0xfffe;
/* * Battery life time - LAN PCIe should enter ASPM L1 to save diff --git a/src/mainboard/google/rambi/variants/ninja/lan.c b/src/mainboard/google/rambi/variants/ninja/lan.c index e5688df..a6812e6 100644 --- a/src/mainboard/google/rambi/variants/ninja/lan.c +++ b/src/mainboard/google/rambi/variants/ninja/lan.c @@ -3,6 +3,7 @@ #include <cbfs.h> #include <types.h> #include <arch/io.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> @@ -143,7 +144,7 @@ ethernet_dev = dev_find_device(NINJA_NIC_VENDOR_ID, NINJA_NIC_DEVICE_ID, 0); if (ethernet_dev != NULL) { - io_base = pci_read_config16(ethernet_dev, 0x10) & 0xfffe; + io_base = pci_read_config16(ethernet_dev, PCI_BASE_ADDRESS_0) & 0xfffe;
/* * Battery life time - LAN PCIe should enter ASPM L1 to save diff --git a/src/mainboard/google/rambi/variants/sumo/lan.c b/src/mainboard/google/rambi/variants/sumo/lan.c index 53bd4fb..fab327e 100644 --- a/src/mainboard/google/rambi/variants/sumo/lan.c +++ b/src/mainboard/google/rambi/variants/sumo/lan.c @@ -3,6 +3,7 @@ #include <cbfs.h> #include <types.h> #include <arch/io.h> +#include <device/pci_def.h> #include <device/pci_ops.h> #include <console/console.h> #include <device/device.h> @@ -143,7 +144,7 @@ ethernet_dev = dev_find_device(SUMO_NIC_VENDOR_ID, SUMO_NIC_DEVICE_ID, 0); if (ethernet_dev != NULL) { - io_base = pci_read_config16(ethernet_dev, 0x10) & 0xfffe; + io_base = pci_read_config16(ethernet_dev, PCI_BASE_ADDRESS_0) & 0xfffe;
/* * Battery life time - LAN PCIe should enter ASPM L1 to save
HAOUAS Elyes has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/44828 )
Change subject: mb/google: Use 'PCI_*' macros instead of magic number ......................................................................
mb/google: Use 'PCI_*' macros instead of magic number
Change-Id: I55b7c3d895e560a0716415001a2d9e8c4d69ca7b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/auron/variants/buddy/variant.c M src/mainboard/google/beltino/lan.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/jecht/lan.c M src/mainboard/google/rambi/variants/ninja/lan.c M src/mainboard/google/rambi/variants/sumo/lan.c 6 files changed, 12 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/44828/2
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44828
to look at the new patch set (#3).
Change subject: mb/google: Use 'PCI_BASE_ADDRESS_0' instead of magic number ......................................................................
mb/google: Use 'PCI_BASE_ADDRESS_0' instead of magic number
Change-Id: I55b7c3d895e560a0716415001a2d9e8c4d69ca7b Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/auron/variants/buddy/variant.c M src/mainboard/google/beltino/lan.c M src/mainboard/google/butterfly/mainboard.c M src/mainboard/google/jecht/lan.c M src/mainboard/google/rambi/variants/ninja/lan.c M src/mainboard/google/rambi/variants/sumo/lan.c 6 files changed, 12 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/44828/3
-
HAOUAS Elyes (Code Review)