Attention is currently required from: Angel Pons, Maximilian Brune.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )
Change subject: [RFC] drivers/option: Add option list in cbtable
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/option/cfr.h:
https://review.coreboot.org/c/coreboot/+/74121/comment/d0bcbcec_527e9aa2
PS1, Line 71: /* struct cfr_string opt_name; */
: /* struct cfr_string ui_name; */
: /* struct lb_cfr_enum_value enum_values[]; */
Might have a problem parsing these variable length fields because the length field of a `cfr_string` […]
Ah, possibly 'string length' and 'actual length' fields? I think it's fine though: just need to align the pointer after walking over an individual `cfr_string`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74121
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772
Gerrit-Change-Number: 74121
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Maslowski
info@orangecms.org
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Comment-Date: Sat, 15 Apr 2023 05:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment