Change in coreboot[master]: soc/intel/common/block: add code for ACPI CPPC entries generation - coreboot-gerrit

13 Nov 2020


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45535 )
Change subject: soc/intel/common/block: add code for ACPI CPPC entries generation
......................................................................
Patch Set 35:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45535/35/src/soc/intel/common/block... 
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/45535/35/src/soc/intel/common/block... 
PS35, Line 399: #if CONFIG(SOC_INTEL_COMMON_BLOCK_ACPI_CPPC)
Do we need this? AFAICS, just dropping this would make `static` work just
fine.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/45535
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fcc2d0d7c6b6f35f8dd011f55dab8469be99d47
Gerrit-Change-Number: 45535
Gerrit-PatchSet: 35
Gerrit-Owner: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Elyes HAOUAS
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Matt Delco delco@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Fri, 13 Nov 2020 10:53:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment