Change in coreboot[master]: soc/intel/xeon_sp/cpx: Fix bootblock size with CBnT - coreboot-gerrit

28 Jan 2021


      Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Christian Walter, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50082 )
Change subject: soc/intel/xeon_sp/cpx: Fix bootblock size with CBnT
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/soc/intel/xeon_sp/cpx/Kconfig:
https://review.coreboot.org/c/coreboot/+/50082/comment/e6376d05_2e3eddb3 
PS1, Line 9: 	select FIXED_BOOTBLOCK_SIZE if INTEL_CBNT_SUPPORT
Shouldn't this be selected the other way around? Make INTEL_CBNT_SUPPORT select FIXED_BOOTBLOCK_SIZE
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50082
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5ad9d29f247b6f828501bfacc27a8af08761d55
Gerrit-Change-Number: 50082
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang jonzhang@fb.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Thu, 28 Jan 2021 17:30:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment