Hello Raul Rangel, Felix Held,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/42532
to review the following change.
Change subject: cbmem: Remove IDs for TSEG and BERT ......................................................................
cbmem: Remove IDs for TSEG and BERT
Remove the changes added in 80df052d3 cbmem: Add IDs for TSEG and BERT table data
No platform uses either ID. TSEG in cbmem is incompatible with stage cache. BERT reserved data in cbmem is unusable in Linux.
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I5501424bfeb38d5ff5432678df9e08b4c16258f6 --- M src/commonlib/include/commonlib/cbmem_id.h 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/42532/1
diff --git a/src/commonlib/include/commonlib/cbmem_id.h b/src/commonlib/include/commonlib/cbmem_id.h index 65973c3..ac271a0 100644 --- a/src/commonlib/include/commonlib/cbmem_id.h +++ b/src/commonlib/include/commonlib/cbmem_id.h @@ -46,8 +46,6 @@ #define CBMEM_ID_ROMSTAGE_RAM_STACK 0x90357ac4 #define CBMEM_ID_ROOT 0xff4007ff #define CBMEM_ID_SMBIOS 0x534d4254 -#define CBMEM_ID_BERT_RAW_DATA 0x42455254 -#define CBMEM_ID_SMM_TSEG_SPACE 0x54534547 #define CBMEM_ID_SMM_SAVE_SPACE 0x07e9acee #define CBMEM_ID_STAGEx_META 0x57a9e000 #define CBMEM_ID_STAGEx_CACHE 0x57a9e100 @@ -113,8 +111,6 @@ { CBMEM_ID_ROMSTAGE_RAM_STACK, "ROMSTG STCK" }, \ { CBMEM_ID_ROOT, "CBMEM ROOT " }, \ { CBMEM_ID_SMBIOS, "SMBIOS " }, \ - { CBMEM_ID_BERT_RAW_DATA, "BERT DATA " }, \ - { CBMEM_ID_SMM_TSEG_SPACE, "TSEG " }, \ { CBMEM_ID_SMM_SAVE_SPACE, "SMM BACKUP " }, \ { CBMEM_ID_STORAGE_DATA, "SD/MMC/eMMC" }, \ { CBMEM_ID_TCPA_LOG, "TCPA LOG " }, \
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42532 )
Change subject: cbmem: Remove IDs for TSEG and BERT ......................................................................
Patch Set 1: Code-Review+2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42532 )
Change subject: cbmem: Remove IDs for TSEG and BERT ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42532 )
Change subject: cbmem: Remove IDs for TSEG and BERT ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/42532/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42532/1//COMMIT_MSG@10 PS1, Line 10: 80df052d3 cbmem: Add IDs for TSEG and BERT table data nit: use "commit 80df052d3" so that Gerrit automatically links to the commit?
Hello build bot (Jenkins), Raul Rangel, Angel Pons, Aaron Durbin, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42532
to look at the new patch set (#2).
Change subject: cbmem: Remove IDs for TSEG and BERT ......................................................................
cbmem: Remove IDs for TSEG and BERT
Remove the changes added in commit 80df052d3 "cbmem: Add IDs for TSEG and BERT table data"
No platform uses either ID. TSEG in cbmem is incompatible with stage cache. BERT reserved data in cbmem is unusable in Linux.
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I5501424bfeb38d5ff5432678df9e08b4c16258f6 --- M src/commonlib/include/commonlib/cbmem_id.h 1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/42532/2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42532 )
Change subject: cbmem: Remove IDs for TSEG and BERT ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42532/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42532/1//COMMIT_MSG@10 PS1, Line 10: 80df052d3 cbmem: Add IDs for TSEG and BERT table data
nit: use "commit 80df052d3" so that Gerrit automatically links to the commit?
Thanks for the tip
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42532 )
Change subject: cbmem: Remove IDs for TSEG and BERT ......................................................................
cbmem: Remove IDs for TSEG and BERT
Remove the changes added in commit 80df052d3 "cbmem: Add IDs for TSEG and BERT table data"
No platform uses either ID. TSEG in cbmem is incompatible with stage cache. BERT reserved data in cbmem is unusable in Linux.
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: I5501424bfeb38d5ff5432678df9e08b4c16258f6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42532 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/commonlib/include/commonlib/cbmem_id.h 1 file changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Felix Held: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/commonlib/include/commonlib/cbmem_id.h b/src/commonlib/include/commonlib/cbmem_id.h index 65973c3..ac271a0 100644 --- a/src/commonlib/include/commonlib/cbmem_id.h +++ b/src/commonlib/include/commonlib/cbmem_id.h @@ -46,8 +46,6 @@ #define CBMEM_ID_ROMSTAGE_RAM_STACK 0x90357ac4 #define CBMEM_ID_ROOT 0xff4007ff #define CBMEM_ID_SMBIOS 0x534d4254 -#define CBMEM_ID_BERT_RAW_DATA 0x42455254 -#define CBMEM_ID_SMM_TSEG_SPACE 0x54534547 #define CBMEM_ID_SMM_SAVE_SPACE 0x07e9acee #define CBMEM_ID_STAGEx_META 0x57a9e000 #define CBMEM_ID_STAGEx_CACHE 0x57a9e100 @@ -113,8 +111,6 @@ { CBMEM_ID_ROMSTAGE_RAM_STACK, "ROMSTG STCK" }, \ { CBMEM_ID_ROOT, "CBMEM ROOT " }, \ { CBMEM_ID_SMBIOS, "SMBIOS " }, \ - { CBMEM_ID_BERT_RAW_DATA, "BERT DATA " }, \ - { CBMEM_ID_SMM_TSEG_SPACE, "TSEG " }, \ { CBMEM_ID_SMM_SAVE_SPACE, "SMM BACKUP " }, \ { CBMEM_ID_STORAGE_DATA, "SD/MMC/eMMC" }, \ { CBMEM_ID_TCPA_LOG, "TCPA LOG " }, \
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
Felix Held (Code Review)
-
Marshall Dawson (Code Review)