Attention is currently required from: Sean Rhodes, Matt DeVillier. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61620 )
Change subject: payloads/tianocore: Rework Makefile ......................................................................
Patch Set 20:
(2 comments)
File payloads/external/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/61620/comment/3bafcece_a34df267 PS20, Line 139: $(obj)/UEFIPAYLOAD.fd ${CONFIG_PAYLOAD_FILE} ?
File payloads/external/tianocore/Makefile:
https://review.coreboot.org/c/coreboot/+/61620/comment/5e85019e_5033c69d PS20, Line 146: */ Any reason this change is needed? I think it might be better to keep the directories specific. I'll frequently rename a directory to save it for comparison. One could argue whether or not distclean should get rid of that, but I don't think that's been the policy up to this point.
-
Martin Roth (Code Review)