HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44307 )
Change subject: arch/x86: Add support for ASan to memory functions
......................................................................
Patch Set 5:
Patch Set 5:
Patch Set 5:
Patch Set 5:
Patch Set 5:
Patch Set 5:
see https://review.coreboot.org/c/coreboot/+/44656
Thanks for the fix. Wouldn't it be better if we replace stdbool.h with types.h in memcpy.c, memset.c and memmove.c?
or we could just add stdint.h to these files.
you mean stddef for "size_t" ?
Yeah. I was thinking of adding stdint.h and stddef.h in the above files. But later after talking to Patrick, I realized that it was much better to add these includes in asan.h, like what you did in your patch, because the header itself was using them. So, thank you for the fix.
You are welcome.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44307
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2030437636c77aea7cccda8efe050df4b77c15c7
Gerrit-Change-Number: 44307
Gerrit-PatchSet: 5
Gerrit-Owner: Harshit Sharma
harshitsharmajs@gmail.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 23 Aug 2020 09:45:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment