Attention is currently required from: Tim Wawrzynczak, Andrey Petrov, Patrick Rudolph. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58987 )
Change subject: drivers/intel/fsp2_0: Add preload_fspm and preload_fsps ......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58987/comment/1c4ddc4f_92710f9a PS2, Line 8: : FSP is normally memmapped and then decompressed.
nit: this is only true in the non-XIP world, it cannot be decompressed "in-place" on Intel platforms […]
Done
File src/drivers/intel/fsp2_0/memory_init.c:
https://review.coreboot.org/c/coreboot/+/58987/comment/ef3160a2_77e6d75d PS2, Line 349:
nit: extra blank line
Done
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/58987/comment/a10d237a_b1609145 PS2, Line 239:
same
Done