Attention is currently required from: Maulik V Vaghela, Subrata Banik, Patrick Rudolph, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59209 )
Change subject: soc/intel/common/thermal: Allow thermal configuration over PMC
......................................................................
Patch Set 13: Code-Review+2
(2 comments)
Patchset:
PS13:
thanks Subrata, this is a lot cleaner 😊
File src/soc/intel/common/block/thermal/thermal_pmc.c:
https://review.coreboot.org/c/coreboot/+/59209/comment/5533f266_e3f86f26
PS13, Line 3: #include <console/console.h>
looks unused
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c6ae72610da39fc18ff252c440d006e83c570a0
Gerrit-Change-Number: 59209
Gerrit-PatchSet: 13
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 19 Nov 2021 20:14:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment