Change in coreboot[master]: mb/google/zork: Mark RW_MRC_CACHE as "Preserve"

[Martin Roth (Code Review)]

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47776 )

Change subject: mb/google/zork: Mark RW_MRC_CACHE as "Preserve"
......................................................................

mb/google/zork: Mark RW_MRC_CACHE as "Preserve"

AGESA checks to make sure that the firmware version reading the MRC
cache is the same version that wrote it, so it doesn't need to be
erased during a firmware update.

BUG=b:173724014
TEST=Flash firmware to DUT, update firmware, check RW_MRC_CACHE was
not erased
BRANCH=Zork

Signed-off-by: Martin Roth 
Change-Id: Ice3d1d467c25366b7ef678cd6481d043f62644ca
---
M src/mainboard/google/zork/chromeos.fmd
1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/47776/1

diff --git a/src/mainboard/google/zork/chromeos.fmd b/src/mainboard/google/zork/chromeos.fmd
index 7c2b95b..be43e8a 100644
--- a/src/mainboard/google/zork/chromeos.fmd
+++ b/src/mainboard/google/zork/chromeos.fmd
@@ -1,6 +1,6 @@
 FLASH@0xFF000000 16M {
    SI_BIOS {
-		RW_MRC_CACHE 64K
+		RW_MRC_CACHE(PRESERVE) 64K
    	RW_SECTION_A 3M {
    		VBLOCK_A 8K
    		FW_MAIN_A(CBFS)

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47776 )

Change subject: mb/google/zork: Mark RW_MRC_CACHE as "Preserve"
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47776 )

Change subject: mb/google/zork: Mark RW_MRC_CACHE as "Preserve"
......................................................................

Patch Set 1:

I wonder if there's a reason to not overwrite this during a firmware update. Or would the ABL erase it a second time?

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47776 )

Change subject: mb/google/zork: Mark RW_MRC_CACHE as "Preserve"
......................................................................

Patch Set 1:
> Patch Set 1:
>
> I wonder if there's a reason to not overwrite this during a firmware update. Or would the ABL erase it a second time?

I would expect that without the change it would get erased twice, i.e. once during the FW update, then again during the first boot.

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47776 )

Change subject: mb/google/zork: Mark RW_MRC_CACHE as "Preserve"
......................................................................

Patch Set 1: Code-Review+1
> Patch Set 1:
> > Patch Set 1:
> >
> > I wonder if there's a reason to not overwrite this during a firmware update. Or would the ABL erase it a second time?
>
> I would expect that without the change it would get erased twice, i.e. once during the FW update, then again during the first boot.

ok

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47776 )

Change subject: mb/google/zork: Mark RW_MRC_CACHE as "Preserve"
......................................................................

mb/google/zork: Mark RW_MRC_CACHE as "Preserve"

AGESA checks to make sure that the firmware version reading the MRC
cache is the same version that wrote it, so it doesn't need to be
erased during a firmware update.

BUG=b:173724014
TEST=Flash firmware to DUT, update firmware, check RW_MRC_CACHE was
not erased
BRANCH=Zork

Signed-off-by: Martin Roth 
Change-Id: Ice3d1d467c25366b7ef678cd6481d043f62644ca
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47776
Tested-by: build bot (Jenkins) 
Reviewed-by: Marshall Dawson 
Reviewed-by: Felix Held 
---
M src/mainboard/google/zork/chromeos.fmd
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, but someone else must approve
  Marshall Dawson: Looks good to me, approved

diff --git a/src/mainboard/google/zork/chromeos.fmd b/src/mainboard/google/zork/chromeos.fmd
index 7c2b95b..be43e8a 100644
--- a/src/mainboard/google/zork/chromeos.fmd
+++ b/src/mainboard/google/zork/chromeos.fmd
@@ -1,6 +1,6 @@
 FLASH@0xFF000000 16M {
    SI_BIOS {
-		RW_MRC_CACHE 64K
+		RW_MRC_CACHE(PRESERVE) 64K
    	RW_SECTION_A 3M {
    		VBLOCK_A 8K
    		FW_MAIN_A(CBFS)