Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41620 )
Change subject: acpi: Add support for call method
......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41620/11//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41620/11//COMMIT_MSG@7
PS11, Line 7: acpi: Add support for call method
The STA method is not mentioned.
https://review.coreboot.org/c/coreboot/+/41620/11//COMMIT_MSG@10
PS11, Line 10: STA function which returns an external variable.
Could be two commits?
https://review.coreboot.org/c/coreboot/+/41620/11/src/acpi/acpigen.c
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/41620/11/src/acpi/acpigen.c@1970
PS11, Line 1970: int
unsigned int
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibcb67bd756dc8ae1dfd2d40020c273325583df0f
Gerrit-Change-Number: 41620
Gerrit-PatchSet: 11
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kiran2 Kumar
kiran2.kumar@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 09 Jun 2020 07:01:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment