Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Johnny Lin, Rocky Phagura, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang.
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49460 )
Change subject: cpu/x86/smm_module_loaderv2: Pass SMM log level via module parameter
......................................................................
Patch Set 2:
(1 comment)
File src/cpu/x86/smm/smm_module_loaderv2.c:
https://review.coreboot.org/c/coreboot/+/49460/comment/14fccb42_8c8ef40f
PS2, Line 639: params->handler_arg = (void *) &smm_param_loglevel;
I don't think you should do this. It changes the definition of the interface. See the smm_loader_params. You could extend the API or the handler_args, but shouldn't hijack them. I don't know if it happens soon enough, but you could also do a mainboard software SMI to pass the loglevel instead of passing it on load, but that may be too late when loading 32+ SMM handlers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81722a4f1bf75ec942cc06e403ad702dfe938e71
Gerrit-Change-Number: 49460
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Rocky Phagura
rphagura@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Rocky Phagura
rphagura@fb.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Comment-Date: Fri, 15 Jan 2021 18:14:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment