Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Jianeng Ceng, Kapil Porwal, Nick Vaccaro, Rishika Raj, Shou-Chieh Hsu, Subrata Banik.
Simon Yang has posted comments on this change by Simon Yang. ( https://review.coreboot.org/c/coreboot/+/84098?usp=email )
Change subject: mb/google/nissa/var/anraggar: Force audio mute to avoid screen flick
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84098/comment/9ed02e07_78d31aa5?usp... :
PS3, Line 8:
: Panel CSOT MNB601LS1-3 will flicker once during enter Chrome login screen,
: it is because it inserts 12 blank frames if it receives the unmute in VB-ID.
:
wrap up text ?
Done
File src/mainboard/google/brya/variants/anraggar/variant.c:
https://review.coreboot.org/c/coreboot/+/84098/comment/2204f145_b651e11f?usp... :
PS3, Line 53: * Panel CSOT MNB601LS1-3 will flicker once during enter Chrome login screen,
: * it is because it inserts 12 blank frames if it receives the unmute in VB-ID.
: *
: * Always override the mute in VB-ID to avoid Tcon EC detected the
: * audiomute_flag change.
: *
need one space to start with
Done
https://review.coreboot.org/c/coreboot/+/84098/comment/4633bee8_e0e55796?usp... :
PS3, Line 59: u32 ddi_buf_ctl2 = graphics_gtt_read(TRANS_DDI_FUNC_CTL2_A);
: graphics_gtt_write(TRANS_DDI_FUNC_CTL2_A,
: ddi_buf_ctl2 |= TRANS_DDI_FORCE_AUDIO_MUTE);
use `graphics_gtt_rmw`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84098?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I711dfd0803440e4b04f02849fed529c3872e023d
Gerrit-Change-Number: 84098
Gerrit-PatchSet: 5
Gerrit-Owner: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Rishika Raj
rishikaraj@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Rishika Raj
rishikaraj@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Jianeng Ceng
cengjianeng@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 27 Aug 2024 13:23:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com