Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63074 )
(
16 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/sifive/ux00ddr.h: Remove set but unused variables ......................................................................
soc/sifive/ux00ddr.h: Remove set but unused variables
It looks like this code was not finished so it's left commented out for now.
Change-Id: I442a42e297f2968dd2c824a93a9a1e2bc74ea2f4 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/63074 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/sifive/fu540/ux00ddr.h 1 file changed, 20 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/sifive/fu540/ux00ddr.h b/src/soc/sifive/fu540/ux00ddr.h index cc67508..bf856f3 100644 --- a/src/soc/sifive/fu540/ux00ddr.h +++ b/src/soc/sifive/fu540/ux00ddr.h @@ -176,10 +176,10 @@ if (failc0 || failc1) { //if (fails==0) uart_puts((void*) UART0_CTRL_ADDR, "DDR error in fixing up \n"); fails |= (1<<dq); - char slicelsc = '0'; - char slicemsc = '0'; - slicelsc += (dq % 10); - slicemsc += (dq / 10); + /* char slicelsc = '0'; */ + /* char slicemsc = '0'; */ + /* slicelsc += (dq % 10); */ + /* slicemsc += (dq / 10); */ //uart_puts((void*) UART0_CTRL_ADDR, "S "); //uart_puts((void*) UART0_CTRL_ADDR, &slicemsc); //uart_puts((void*) UART0_CTRL_ADDR, &slicelsc);