Change in coreboot[master]: cpu/x86/64bit: Generate static page tables from an assembly file - coreboot-gerrit

20 Apr 2022


      Attention is currently required from: Patrick Rudolph, Arthur Heymans.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63725 )
Change subject: cpu/x86/64bit: Generate static page tables from an assembly file
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Patchset:
PS3: 
Couldn't one generate the assembly file at build time using a tool?
File src/cpu/x86/64bit/pt.S:
https://review.coreboot.org/c/coreboot/+/63725/comment/4fb4b570_f570f9c4 
PS3, Line 4: ArchitectureProgrammer
nit: missing a space
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/63725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1e31b701a2584268c85d327bf139953213899e3
Gerrit-Change-Number: 63725
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 20 Apr 2022 08:33:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment