Change in ...coreboot[master]: mb/google/octopus/variants/bloog: Set tcc offset for bloog

[Tony Huang (Code Review)]

Tony Huang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33461

Change subject: mb/google/octopus/variants/bloog: Set tcc offset for bloog
......................................................................

mb/google/octopus/variants/bloog: Set tcc offset for bloog

Change tcc offset from 0 to 10 degree celsius for bloog.

BUG=b:135225497
BRANCH=octopus
TEST=Build and verify test result by thermal team.

Change-Id: I4cbff846914a776c67692005f8b40cd73cfaf231
Signed-off-by: Tony Huang 
---
M src/mainboard/google/octopus/variants/bloog/overridetree.cb
1 file changed, 3 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/33461/1

diff --git a/src/mainboard/google/octopus/variants/bloog/overridetree.cb b/src/mainboard/google/octopus/variants/bloog/overridetree.cb
index cf70bb3..6c64ba7 100644
--- a/src/mainboard/google/octopus/variants/bloog/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/bloog/overridetree.cb
@@ -53,6 +53,9 @@
         #| I2C6              | Trackpad                  |
         #| I2C7              | Touchscreen               |
         #+-------------------+---------------------------+
+
+        register "tcc_offset" = "10"
+
         register "common_soc_config" = "{
                 .gspi[0] = {
                         .speed_mhz = 1,

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33461 )

Change subject: mb/google/octopus/variants/bloog: Set tcc offset for bloog
......................................................................

Patch Set 1: Code-Review+1

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33461 )

Change subject: mb/google/octopus/variants/bloog: Set tcc offset for bloog
......................................................................

Patch Set 1: Code-Review+2

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33461 )

Change subject: mb/google/octopus/variants/bloog: Set tcc offset for bloog
......................................................................

Patch Set 1: Code-Review+2

[Tony Huang (Code Review)]

Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33461 )

Change subject: mb/google/octopus/variants/bloog: Set tcc offset for bloog
......................................................................

Patch Set 1:

Hi Furquan,
Could you please help cherry-pick to chromium ToT?
Thanks

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33461 )

Change subject: mb/google/octopus/variants/bloog: Set tcc offset for bloog
......................................................................

mb/google/octopus/variants/bloog: Set tcc offset for bloog

Change tcc offset from 0 to 10 degree celsius for bloog.

BUG=b:135225497
BRANCH=octopus
TEST=Build and verify test result by thermal team.

Change-Id: I4cbff846914a776c67692005f8b40cd73cfaf231
Signed-off-by: Tony Huang 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33461
Tested-by: build bot (Jenkins) 
Reviewed-by: Marco Chen 
Reviewed-by: Furquan Shaikh 
Reviewed-by: Justin TerAvest 
---
M src/mainboard/google/octopus/variants/bloog/overridetree.cb
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Justin TerAvest: Looks good to me, approved
  Marco Chen: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/octopus/variants/bloog/overridetree.cb b/src/mainboard/google/octopus/variants/bloog/overridetree.cb
index cf70bb3..6c64ba7 100644
--- a/src/mainboard/google/octopus/variants/bloog/overridetree.cb
+++ b/src/mainboard/google/octopus/variants/bloog/overridetree.cb
@@ -53,6 +53,9 @@
         #| I2C6              | Trackpad                  |
         #| I2C7              | Touchscreen               |
         #+-------------------+---------------------------+
+
+        register "tcc_offset" = "10"
+
         register "common_soc_config" = "{
                 .gspi[0] = {
                         .speed_mhz = 1,

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33461 )

Change subject: mb/google/octopus/variants/bloog: Set tcc offset for bloog
......................................................................

Patch Set 2:
> Patch Set 1:
>
> Hi Furquan,
> Could you please help cherry-pick to chromium ToT?
> Thanks

Done: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+...