HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40827 )
Change subject: mb/x9scl/early_init: Remove unused includes ......................................................................
mb/x9scl/early_init: Remove unused includes
Change-Id: I455a43ab6c4931a4fb1f717a65013b6b7cefb777 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/supermicro/x9scl/early_init.c 1 file changed, 1 insertion(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/40827/1
diff --git a/src/mainboard/supermicro/x9scl/early_init.c b/src/mainboard/supermicro/x9scl/early_init.c index b4a39fe..a2f89e7 100644 --- a/src/mainboard/supermicro/x9scl/early_init.c +++ b/src/mainboard/supermicro/x9scl/early_init.c @@ -1,25 +1,18 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
-/* FIXME: Check if all includes are needed. */ - #include <stdint.h> -#include <string.h> -#include <timestamp.h> -#include <arch/byteorder.h> -#include <device/mmio.h> #include <device/pci_ops.h> #include <device/pnp_def.h> #include <device/pnp_ops.h> -#include <console/console.h> #include <bootblock_common.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> -#include <southbridge/intel/common/gpio.h> #include <superio/nuvoton/common/nuvoton.h> #include <superio/nuvoton/nct6776/nct6776.h> #include <superio/nuvoton/wpcm450/wpcm450.h> + #include "x9scl.h"
#define SERIAL_DEV PNP_DEV(X9SCL_NCT6776_PNP_BASE, NCT6776_SP1)
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40827 )
Change subject: mb/x9scl/early_init: Remove unused includes ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40827 )
Change subject: mb/x9scl/early_init: Remove unused includes ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40827 )
Change subject: mb/x9scl/early_init: Remove unused includes ......................................................................
mb/x9scl/early_init: Remove unused includes
Change-Id: I455a43ab6c4931a4fb1f717a65013b6b7cefb777 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/40827 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/supermicro/x9scl/early_init.c 1 file changed, 1 insertion(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/supermicro/x9scl/early_init.c b/src/mainboard/supermicro/x9scl/early_init.c index b4a39fe..a2f89e7 100644 --- a/src/mainboard/supermicro/x9scl/early_init.c +++ b/src/mainboard/supermicro/x9scl/early_init.c @@ -1,25 +1,18 @@ /* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
-/* FIXME: Check if all includes are needed. */ - #include <stdint.h> -#include <string.h> -#include <timestamp.h> -#include <arch/byteorder.h> -#include <device/mmio.h> #include <device/pci_ops.h> #include <device/pnp_def.h> #include <device/pnp_ops.h> -#include <console/console.h> #include <bootblock_common.h> #include <northbridge/intel/sandybridge/sandybridge.h> #include <northbridge/intel/sandybridge/raminit_native.h> #include <southbridge/intel/bd82x6x/pch.h> -#include <southbridge/intel/common/gpio.h> #include <superio/nuvoton/common/nuvoton.h> #include <superio/nuvoton/nct6776/nct6776.h> #include <superio/nuvoton/wpcm450/wpcm450.h> + #include "x9scl.h"
#define SERIAL_DEV PNP_DEV(X9SCL_NCT6776_PNP_BASE, NCT6776_SP1)
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40827 )
Change subject: mb/x9scl/early_init: Remove unused includes ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3253 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3252 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3251 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3250
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)