Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/19613 )
Change subject: intelmetool: Enable warning *set-but-unused-variable* ......................................................................
intelmetool: Enable warning *set-but-unused-variable*
There are no GCC warnings anymore about set but unused variables, and Clang warns about this switch, as it doesn’t know it.
So remove the switch to use the default set by the switch `Wall`.
Change-Id: Ie9eb26d4f8b298af231b952b547b71d68c649eaf Signed-off-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-on: https://review.coreboot.org/19613 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Philippe Mathieu-Daudé philippe.mathieu.daude@gmail.com Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com --- M util/intelmetool/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Philippe Mathieu-Daudé: Looks good to me, but someone else must approve Philipp Deppenwiese: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/util/intelmetool/Makefile b/util/intelmetool/Makefile index affcf30..8857d95 100644 --- a/util/intelmetool/Makefile +++ b/util/intelmetool/Makefile @@ -17,7 +17,7 @@ CC ?= gcc INSTALL ?= /usr/bin/install PREFIX ?= /usr/local -CFLAGS ?= -O0 -g -Wall -W -Wno-unused-parameter -Wno-unused-but-set-variable -Wno-sign-compare -Wno-unused-function +CFLAGS ?= -O0 -g -Wall -W -Wno-unused-parameter -Wno-sign-compare -Wno-unused-function LDFLAGS += -lpci -lz
OBJS = intelmetool.o me.o me_status.o mmap.o