Change in coreboot[master]: soc/intel/icelake: adapt FSP GOP param to match the other FSP2.0 plat...
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36353 )
Change subject: soc/intel/icelake: adapt FSP GOP param to match the other FSP2.0 platforms ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36353/2/src/soc/intel/icelake/fsp_p... File src/soc/intel/icelake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/36353/2/src/soc/intel/icelake/fsp_p... PS2, Line 96: /* Only initialize graphics if supported and enabled */
I see no check if it's supported?
implicitly; CONFIG(RUN_FSP_GOP) would be FALSE if not supported, too
https://review.coreboot.org/c/coreboot/+/36353/2/src/soc/intel/icelake/fsp_p... PS2, Line 100: params->GtFreqMax = 2;
I don't think this should depend on the GOP execution.
indeed; this was caused by my misunderstanding we have discussed on IRC; will fix this
-
Michael Niewöhner (Code Review)