Attention is currently required from: Cliff Huang, Pranava Y N, Subrata Banik.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84405?usp=email )
Change subject: mb/google/fatcat: Add GPIO settings
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/fatcat/variants/fatcat/gpio.c:
https://review.coreboot.org/c/coreboot/+/84405/comment/728f0dc5_39b78a60?usp... :
PS1, Line 10: /* GPP_A */
Those GPP group comments are generated from the script.
Done
https://review.coreboot.org/c/coreboot/+/84405/comment/dde0f227_990cb772?usp... :
PS1, Line 422: /* GPP_H10: UART0_BUF_RTS */
: PAD_CFG_NF(GPP_H10, NONE, DEEP, NF1),
: /* GPP_H11: UART0_BUF_CTS */
: PAD_CFG_NF(GPP_H11, NONE, DEEP, NF1),
I don't think u need these
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84405?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d52
Gerrit-Change-Number: 84405
Gerrit-PatchSet: 2
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Wed, 18 Sep 2024 23:05:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang
cliff.huang@intel.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com