Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42708 )
Change subject: AGESA fam14: Use AMD_ACPIMMIO_GPIO_BASE_100 ......................................................................
Patch Set 6:
(2 comments)
Patch Set 3: Code-Review+1
Could you please add a comment in src/soc/amd/common/block/include/amdblocks/acpimmio_map.h describing this only applies to certain families? That macro is not correct for all chipsets.
https://review.coreboot.org/c/coreboot/+/42708/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42708/2//COMMIT_MSG@9 PS2, Line 9: direclty
directly
Done
https://review.coreboot.org/c/coreboot/+/42708/4/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/42708/4/src/soc/amd/common/block/in... PS4, Line 36: /* Family 14h or before */
works for me.
Removed the comment here, added more details to CB:37324.