Attention is currently required from: Hung-Te Lin, Kenji Yu, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85516?usp=email )
Change subject: soc/mediatek/mt8196: Initialize SSPM ......................................................................
Patch Set 17:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85516/comment/8b472073_a917d005?usp... : PS15, Line 11: enable
enable it
Done
File src/soc/mediatek/common/include/soc/sspm.h:
https://review.coreboot.org/c/coreboot/+/85516/comment/37310035_5ea7153e?usp... : PS15, Line 13: void sspm_enable_sram(void);
Can we add a blank line above, and another blank line below `sspm_init`?
Done
File src/soc/mediatek/common/sspm.c:
https://review.coreboot.org/c/coreboot/+/85516/comment/aed7e9d1_99be383f?usp... : PS15, Line 19: void sspm_init(void) : { : sspm.load_buffer = _dram_dma; : sspm.buffer_size = REGION_SIZE(dram_dma); : : mtk_init_mcu(&sspm); : }
Done
File src/soc/mediatek/mt8196/soc.c:
https://review.coreboot.org/c/coreboot/+/85516/comment/f78e8c42_61c46857?usp... : PS15, Line 30: sspm_enable_sram();
remove
Done
File src/soc/mediatek/mt8196/sspm_sram.c:
https://review.coreboot.org/c/coreboot/+/85516/comment/ebb94798_b29e463e?usp... : PS15, Line 14: (
remove
Done