Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Sridhar Siricilla.
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62272 )
Change subject: soc/intel/adl: Send EOP early in the boot sequence
......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62272/comment/1f23f331_2fd7f0c5
PS5, Line 7: alder lake
`adl`
Ack
File src/soc/intel/alderlake/chip.c:
https://review.coreboot.org/c/coreboot/+/62272/comment/e76fc989_057914f9
PS6, Line 158: early
I would avoid saying `early` here, sending a cmd post FSP-S is not actually "early" IMO, hence, I wo […]
Ack
https://review.coreboot.org/c/coreboot/+/62272/comment/600bb28a_33a2a54d
PS6, Line 161:
did u miss SOC_INTEL_CSE_SEND_EOP_EARLY check here ?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62272
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9401d5e36ad43cdc0dfe947aabc82528d824df9b
Gerrit-Change-Number: 62272
Gerrit-PatchSet: 7
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Tue, 08 Mar 2022 07:39:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment