Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43978 )
Change subject: acpi: Fix dptf_write_fan_perf to include Revision field ......................................................................
acpi: Fix dptf_write_fan_perf to include Revision field
When emitting a fan's _FPS (Fan Performance States) table, the revision field was missing. According to ACPI spec 6.3, the current revision is zero, so add that Package entry before the others.
BUG=b:149722146 TEST=verified first element of _SB.DPTF.TFN1._FPS is 0
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: If16d4751f1d924807f5087d93b348e58d5265197 --- M src/acpi/acpigen_dptf.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43978/1
diff --git a/src/acpi/acpigen_dptf.c b/src/acpi/acpigen_dptf.c index 0c44b8f..b3cc37a 100644 --- a/src/acpi/acpigen_dptf.c +++ b/src/acpi/acpigen_dptf.c @@ -17,6 +17,7 @@ DEFAULT_TRIP_POINT = 0xFFFFFFFFull, DEFAULT_WEIGHT = 100, DPTF_MAX_ART_THRESHOLDS = 10, + FPS_REVISION = 0, PPCC_REVISION = 2, RAPL_PL1_INDEX = 0, RAPL_PL2_INDEX = 1, @@ -353,7 +354,8 @@
/* _FPS - Fan Performance States */ acpigen_write_name("_FPS"); - pkg_count = acpigen_write_package(0); + pkg_count = acpigen_write_package(1); /* 1 for Revision */ + acpigen_write_integer(FPS_REVISION); /* revision */
for (i = 0; i < max_count; ++i) { /*
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43978 )
Change subject: acpi: Fix dptf_write_fan_perf to include Revision field ......................................................................
Patch Set 1: Code-Review+2
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43978 )
Change subject: acpi: Fix dptf_write_fan_perf to include Revision field ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43978 )
Change subject: acpi: Fix dptf_write_fan_perf to include Revision field ......................................................................
acpi: Fix dptf_write_fan_perf to include Revision field
When emitting a fan's _FPS (Fan Performance States) table, the revision field was missing. According to ACPI spec 6.3, the current revision is zero, so add that Package entry before the others.
BUG=b:149722146 TEST=verified first element of _SB.DPTF.TFN1._FPS is 0
Signed-off-by: Tim Wawrzynczak twawrzynczak@chromium.org Change-Id: If16d4751f1d924807f5087d93b348e58d5265197 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43978 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Sumeet R Pawnikar sumeet.r.pawnikar@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/acpi/acpigen_dptf.c 1 file changed, 3 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Sumeet R Pawnikar: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/acpi/acpigen_dptf.c b/src/acpi/acpigen_dptf.c index 0c44b8f..b3cc37a 100644 --- a/src/acpi/acpigen_dptf.c +++ b/src/acpi/acpigen_dptf.c @@ -17,6 +17,7 @@ DEFAULT_TRIP_POINT = 0xFFFFFFFFull, DEFAULT_WEIGHT = 100, DPTF_MAX_ART_THRESHOLDS = 10, + FPS_REVISION = 0, PPCC_REVISION = 2, RAPL_PL1_INDEX = 0, RAPL_PL2_INDEX = 1, @@ -353,7 +354,8 @@
/* _FPS - Fan Performance States */ acpigen_write_name("_FPS"); - pkg_count = acpigen_write_package(0); + pkg_count = acpigen_write_package(1); /* 1 for Revision */ + acpigen_write_integer(FPS_REVISION); /* revision */
for (i = 0; i < max_count; ++i) { /*
-
Angel Pons (Code Review) -
Sumeet R Pawnikar (Code Review)
-
Tim Wawrzynczak (Code Review)