Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons.
Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62759 )
Change subject: hp/z220_cmt_workstation: Add variant of z220_sff_workstation
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62759/comment/8bef782e_70e8d42a
PS2, Line 11: The code in this commit is untested as I reworked his port into a variant.
Please do a separate commit to turn it into a variant.
Felix: The code that works on CMT from my friend is not in the tree yet, there's no point committing an almost identical clone of the SFF board and then a new commit that removes the CMT port and converts it to a variant. Let's just test the new variant on a CMT and verify that the SFF is still identical (?)
Patchset:
PS2:
Thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62759
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I187dba9d9332aa3a8ee9207fc224a7d87da22c6f
Gerrit-Change-Number: 62759
Gerrit-PatchSet: 2
Gerrit-Owner: Damien Zammit
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 15 Mar 2022 07:54:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment