Attention is currently required from: Rory Liu, Zhuohao Lee, Alan Huang. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61267 )
Change subject: drivers/net/r8168: Add ASPM control mechanism ......................................................................
Patch Set 4:
(3 comments)
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/61267/comment/a13d9c75_c0bcf48d PS4, Line 252: struct drivers_net_config *config = dev->chip_info; : if (!config || !config->enable_aspm) : return; Seeing the function name, I’d move this outside the function before calling it.
https://review.coreboot.org/c/coreboot/+/61267/comment/b2244cd4_c57ce372 PS4, Line 256: printk(BIOS_INFO, "rtl: enable_aspm_L1.2\n"); Maybe:
rtl: Enable ASPM L1.2
https://review.coreboot.org/c/coreboot/+/61267/comment/d638b719_be5bfdaa PS4, Line 363: /* Enable ASPM_L1.2 */ Comment not needed, as the function name says the same.