Attention is currently required from: Lance Zhao, jacz@semihalf.com, Paul Menzel, Duncan Laurie.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49834 )
Change subject: acpi/acpigen.c: Fix incorrect write calls
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/acpi/acpigen.c:
https://review.coreboot.org/c/coreboot/+/49834/comment/977044dd_fea5997b
PS3, Line 154: void acpigen_write_name_zero(const char *name)
: {
: acpigen_write_name(name);
: acpigen_write_zero();
: }
:
: void acpigen_write_name_one(const char *name)
: {
: acpigen_write_name(name);
: acpigen_write_one();
: }
These functions are unused. I'd rather remove them, since `acpigen_write_integer` and `acpigen_write_name_integer` provide more flexibility.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49834
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I116fd41624a8e8b536d18d747f21d3131b734dfc
Gerrit-Change-Number: 49834
Gerrit-PatchSet: 3
Gerrit-Owner: jacz@semihalf.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: jacz@semihalf.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Duncan Laurie
dlaurie@chromium.org
Gerrit-Comment-Date: Tue, 26 Jan 2021 09:45:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment