[M] Change in coreboot[master]: soc/amd/common/data_fabric/domain: provide amd_pci_domain_fill_ssdt

[Felix Held (Code Review)]

Attention is currently required from: Arthur Heymans, Fred Reitberger, Jason Glenesk, Matt DeVillier, Nico Huber, Raul Rangel.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74843?usp=email )

Change subject: soc/amd/common/data_fabric/domain: provide amd_pci_domain_fill_ssdt
......................................................................

Patch Set 11:

(3 comments)

File src/soc/amd/common/block/data_fabric/domain.c:

https://review.coreboot.org/c/coreboot/+/74843/comment/86ba81d1_09f87009 :
PS11, Line 169: 	if (base > PCI_IO_CONFIG_LAST_PORT || limit < PCI_IO_CONFIG_INDEX) {
> I wonder what ACPI says about having a resource producer that covers this […]

i can try that. Arthur's code didn't handle this as a special case, but all reference code i looked at had this handled separately

https://review.coreboot.org/c/coreboot/+/74843/comment/a9306646_7bd1940f :
PS11, Line 176: 			/*spit IO range to not cover PCI config IO ports*/
> Whitspace around comment marks and *split*.

just fixed that in my local tree; will mark this as resolved once i've pushed the new version

https://review.coreboot.org/c/coreboot/+/74843/comment/bc6a8864_f4e22e94 :
PS11, Line 168: 
              : 	if (base > PCI_IO_CONFIG_LAST_PORT || limit < PCI_IO_CONFIG_INDEX) {
              : 		/* no overlap with PCI config IO ports */
              : 		write_ssdt_domain_io_range_helper(base, limit);
              : 	} else {/* overlap with PCI config IO ports */
              : 		if (base == PCI_IO_CONFIG_INDEX && limit == PCI_IO_CONFIG_LAST_PORT)
              : 			return; /* IO range exactly covers the PCI config IO ports */
              : 		if (base < PCI_IO_CONFIG_INDEX && limit > PCI_IO_CONFIG_LAST_PORT) {
              : 			/*spit IO range to not cover PCI config IO ports*/
              : 			write_ssdt_domain_io_range_helper(base, PCI_IO_CONFIG_INDEX - 1);
              : 			write_ssdt_domain_io_range_helper(PCI_IO_CONFIG_LAST_PORT + 1, limit);
              : 		} else if (limit <= PCI_IO_CONFIG_LAST_PORT) {
              : 			write_ssdt_domain_io_range_helper(base, PCI_IO_CONFIG_INDEX - 1);
              : 		} else { /* base >= PCI_IO_CONFIG_INDEX */
              : 			write_ssdt_domain_io_range_helper(PCI_IO_CONFIG_LAST_PORT + 1, limit);
              : 		}
              : 	}
> Much simpler and should work too AFAICT: […]

will look into this to make sure that it covers all cases correctly, but from a quick look it looks good to me