Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42708 )
Change subject: AGESA fam14: Use AMD_ACPIMMIO_GPIO_BASE_100 ......................................................................
Patch Set 4:
(1 comment)
Patch Set 3: Code-Review+1
Could you please add a comment in src/soc/amd/common/block/include/amdblocks/acpimmio_map.h describing this only applies to certain families? That macro is not correct for all chipsets.
https://review.coreboot.org/c/coreboot/+/42708/4/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/42708/4/src/soc/amd/common/block/in... PS4, Line 36: /* Family 14h or before */
It's 100% of the discrete controller hubs, plus Kabini (Family 16h Models 00h-0Fh). […]
I think we could have done without end-of-line comment here, followup moves the banks' descriptions to this file. How about we interleave the full explanation about this GPIO_BASE_100 there?