Attention is currently required from: Felix Held, Henry Sun, Mark Hsieh, Paul Menzel, Reka Norman, Sam McNally, Shou-Chieh Hsu, Tarun Tuli.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75743?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/joxer: Disable storage devices based on fw_config
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brya/variants/joxer/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/75743/comment/cdbe4d9b_6fdf0f62 :
PS5, Line 7: ramstage-$(CONFIG_FW_CONFIG) += variant.c
Are you sure it should be done like that? variant.c also contains `get_wifi_sar_cbfs_filename()`, which does not depend on fw_config, so without it the default WIFI SAR file name will be used instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75743?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6920d88dfec86676ff6733146f748e06d4085c49
Gerrit-Change-Number: 75743
Gerrit-PatchSet: 5
Gerrit-Owner: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Jakub Czapiga
jacz@semihalf.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-Attention: Shou-Chieh Hsu
shouchieh@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 15 Jun 2023 07:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment