Change in ...coreboot[master]: mb/apple/macbookair4_2: ACPI support for EC

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Evgeny Zinoviev (Code Review)

30 May 2019 30 May '19

5:01 a.m.

Evgeny Zinoviev has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33103

Change subject: mb/apple/macbookair4_2: ACPI support for EC ......................................................................

mb/apple/macbookair4_2: ACPI support for EC

Added ACPI support for battery, AC and LID.

I don't have MacBook Air 4,2 to test, but:

- I tested it on 5,2; - I found decompiled DSDT for 4,2 and compared registers and bits, they are the same as on 5,2.

So it should work.

Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M src/mainboard/apple/macbookair4_2/acpi/ec.asl 1 file changed, 5 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33103/1

diff --git a/src/mainboard/apple/macbookair4_2/acpi/ec.asl b/src/mainboard/apple/macbookair4_2/acpi/ec.asl index f70cb3d..cd74865 100644 --- a/src/mainboard/apple/macbookair4_2/acpi/ec.asl +++ b/src/mainboard/apple/macbookair4_2/acpi/ec.asl @@ -1,6 +1,8 @@ /* * This file is part of the coreboot project. * + * Copyright (c) 2019 Evgeny Zinoviev me@ch1p.io + * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; version 2 of the License. @@ -11,10 +13,6 @@ * GNU General Public License for more details. */

-Device(EC) -{ - Name (_HID, EISAID("PNP0C09")) - Name (_UID, 0) - Name (_GPE, 23) -/* FIXME: EC support */ -} +#include <ec/apple/acpi/ec.asl> +#include <ec/apple/acpi/ac_60.asl> +#include <ec/apple/acpi/lid_60.asl>

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

Evgeny Zinoviev (Code Review)

30 May 30 May

5:10 a.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33103

to look at the new patch set (#2).

Change subject: mb/apple/macbookair4_2: ACPI support for EC ......................................................................

mb/apple/macbookair4_2: ACPI support for EC

Added ACPI support for battery, AC and lid.

I don't have MacBook Air 4,2 to test, but:

- I tested it on 5,2; - I found decompiled DSDT for 4,2 and compared registers and bits, they are the same as on 5,2.

So it should work.

Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M src/mainboard/apple/macbookair4_2/acpi/ec.asl 1 file changed, 5 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33103/2

Evgeny Zinoviev (Code Review)

2 Jun 2 Jun

10:45 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33103

to look at the new patch set (#8).

Change subject: mb/apple/macbookair4_2: ACPI support for EC ......................................................................

mb/apple/macbookair4_2: ACPI support for EC

Added ACPI support for battery, AC and lid.

I don't have MacBook Air 4,2 to test, but:

- I tested it on 5,2; - I found decompiled DSDT for 4,2 and compared registers and bits, they are the same as on 5,2.

So it should work.

Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M src/mainboard/apple/macbookair4_2/acpi/ec.asl 1 file changed, 5 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33103/8

Evgeny Zinoviev (Code Review)

10:45 p.m.

New subject: Change in ...coreboot[master]: mb/apple/macbookair4_2: Add ACPI support for EC

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33103

to look at the new patch set (#9).

Change subject: mb/apple/macbookair4_2: Add ACPI support for EC ......................................................................

mb/apple/macbookair4_2: Add ACPI support for EC

Add ACPI support for battery, AC and lid.

I don't have MacBook Air 4,2 to test, but:

- I tested it on 5,2; - I found decompiled DSDT for 4,2 and compared registers and bits, they are the same as on 5,2.

So it should work.

Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M src/mainboard/apple/macbookair4_2/acpi/ec.asl 1 file changed, 5 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33103/9

Felix Held (Code Review)

4 Jun 4 Jun

1:33 p.m.

New subject: Change in ...coreboot[master]: mb/apple/macbookair4_2: Add ACPI support for EC

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33103 )

Change subject: mb/apple/macbookair4_2: Add ACPI support for EC ......................................................................

Patch Set 9: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/33103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Gerrit-Change-Number: 33103 Gerrit-PatchSet: 9 Gerrit-Owner: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 04 Jun 2019 11:33:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

20 Jun 20 Jun

4:47 p.m.

New subject: Change in ...coreboot[master]: mb/apple/macbookair4_2: Add ACPI support for EC

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33103 )

Change subject: mb/apple/macbookair4_2: Add ACPI support for EC ......................................................................

Patch Set 9: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/33103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Gerrit-Change-Number: 33103 Gerrit-PatchSet: 9 Gerrit-Owner: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Thu, 20 Jun 2019 14:47:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Evgeny Zinoviev (Code Review)

2 Feb 2 Feb

7:40 p.m.

New subject: Change in coreboot[master]: mb/apple/macbookair4_2: Add ACPI support for EC

Hello Felix Held, Jacob Garber, Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33103

to look at the new patch set (#10).

Change subject: mb/apple/macbookair4_2: Add ACPI support for EC ......................................................................

mb/apple/macbookair4_2: Add ACPI support for EC

Add ACPI support for battery, AC and lid.

I don't have MacBook Air 4,2 to test, but:

- I tested it on 5,2; - I found decompiled DSDT for 4,2 and compared registers and bits, they are the same as on 5,2.

So it should work.

Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M src/mainboard/apple/macbookair4_2/acpi/ec.asl 1 file changed, 9 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33103/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/33103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Gerrit-Change-Number: 33103 Gerrit-PatchSet: 10 Gerrit-Owner: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

9 Apr 9 Apr

1:04 p.m.

New subject: Change in coreboot[master]: mb/apple/macbookair4_2: Add ACPI support for EC

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33103 )

Change subject: mb/apple/macbookair4_2: Add ACPI support for EC ......................................................................

Patch Set 10: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Gerrit-Change-Number: 33103 Gerrit-PatchSet: 10 Gerrit-Owner: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 09 Apr 2020 11:04:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Evgeny Zinoviev (Code Review)

3 Feb 3 Feb

10:17 p.m.

New subject: Change in coreboot[master]: mb/apple/macbookair4_2: Add ACPI support for EC

Hello build bot (Jenkins), Paul Menzel, Angel Pons, Jacob Garber, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33103

to look at the new patch set (#11).

Change subject: mb/apple/macbookair4_2: Add ACPI support for EC ......................................................................

mb/apple/macbookair4_2: Add ACPI support for EC

Add ACPI support for battery, AC and lid.

I don't have MacBook Air 4,2 to test, but:

- I tested it on 5,2; - I found decompiled DSDT for 4,2 and compared registers and bits, they are the same as on 5,2.

So it should work.

Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Signed-off-by: Evgeny Zinoviev me@ch1p.io --- M src/mainboard/apple/macbookair4_2/acpi/ec.asl 1 file changed, 7 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/33103/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/33103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Gerrit-Change-Number: 33103 Gerrit-PatchSet: 11 Gerrit-Owner: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

10:28 p.m.

New subject: Change in coreboot[master]: mb/apple/macbookair4_2: Add ACPI support for EC

Attention is currently required from: Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33103 )

Change subject: mb/apple/macbookair4_2: Add ACPI support for EC ......................................................................

Patch Set 11: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/33103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Gerrit-Change-Number: 33103 Gerrit-PatchSet: 11 Gerrit-Owner: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Evgeny Zinoviev me@ch1p.io Gerrit-Comment-Date: Wed, 03 Feb 2021 21:28:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

10:29 p.m.

New subject: Change in coreboot[master]: mb/apple/macbookair4_2: Add ACPI support for EC

Attention is currently required from: Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33103 )

Change subject: mb/apple/macbookair4_2: Add ACPI support for EC ......................................................................

Patch Set 11: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/33103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Gerrit-Change-Number: 33103 Gerrit-PatchSet: 11 Gerrit-Owner: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Evgeny Zinoviev me@ch1p.io Gerrit-Comment-Date: Wed, 03 Feb 2021 21:29:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

5 Feb 5 Feb

10:40 a.m.

New subject: Change in coreboot[master]: mb/apple/macbookair4_2: Add ACPI support for EC

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/33103 )

Change subject: mb/apple/macbookair4_2: Add ACPI support for EC ......................................................................

mb/apple/macbookair4_2: Add ACPI support for EC

Add ACPI support for battery, AC and lid.

I don't have MacBook Air 4,2 to test, but:

- I tested it on 5,2; - I found decompiled DSDT for 4,2 and compared registers and bits, they are the same as on 5,2.

So it should work.

Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Signed-off-by: Evgeny Zinoviev me@ch1p.io Reviewed-on: https://review.coreboot.org/c/coreboot/+/33103 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/apple/macbookair4_2/acpi/ec.asl 1 file changed, 7 insertions(+), 7 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/apple/macbookair4_2/acpi/ec.asl b/src/mainboard/apple/macbookair4_2/acpi/ec.asl index 7ee0e29..75f766b 100644 --- a/src/mainboard/apple/macbookair4_2/acpi/ec.asl +++ b/src/mainboard/apple/macbookair4_2/acpi/ec.asl @@ -1,9 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */

-Device(EC) -{ - Name (_HID, EISAID("PNP0C09")) - Name (_UID, 0) - Name (_GPE, 23) -/* FIXME: EC support */ -} +#define LIDS_OFFSET 0x60 +#define HPAC_OFFSET 0x60 +#define WKLD_OFFSET 0x68 + +#include <ec/apple/acpi/ec.asl> +#include <ec/apple/acpi/ac.asl> +#include <ec/apple/acpi/lid.asl>

-- To view, visit https://review.coreboot.org/c/coreboot/+/33103 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I592cb4501c878fe46684a524e729d32fb1d7920c Gerrit-Change-Number: 33103 Gerrit-PatchSet: 12 Gerrit-Owner: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Evgeny Zinoviev me@ch1p.io Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Jacob Garber jgarber1@ualberta.ca Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1176

days inactive

1793

days old

coreboot-gerrit@coreboot.org

11 comments

5 participants

tags (0)

participants (5)

Angel Pons (Code Review)
Evgeny Zinoviev (Code Review)
Felix Held (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)