Change in coreboot[master]: mainboard/starlabs: Add LabTop Mk IV - coreboot-gerrit

18 Dec 2021


      Attention is currently required from: Sean Rhodes, Angel Pons.
Andy Pont has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58428 )
Change subject: mainboard/starlabs: Add LabTop Mk IV
......................................................................
Patch Set 67:
(1 comment)
File src/mainboard/starlabs/labtop/variants/cml/gpio.c:
https://review.coreboot.org/c/coreboot/+/58428/comment/97ea62ce_225322b1 
PS66, Line 14: PAD_CFG_GPI(GPP_H6, NONE, PLTRST),
             : 	PAD_CFG_GPI(GPP_H7, NONE, PLTRST),
...
Am curious about these as well.
GPP_E22, E23, H6, H7 are connected to pull-up or pull-down resistors which give the firmware an indication as to which memory type is fitted.  See comments in romstage.c
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58428
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbaa907dc38dc521961806132f21b7a90324ec9c
Gerrit-Change-Number: 58428
Gerrit-PatchSet: 67
Gerrit-Owner: Sean Rhodes admin@starlabs.systems
Gerrit-Reviewer: Andy Pont andy.pont@sdcsystems.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes admin@starlabs.systems
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 18 Dec 2021 17:00:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment