Change in ...coreboot[master]: mediatek/mt8183: modify vproc12 voltage

[hsin-hsiung wang (Code Review)]

hsin-hsiung wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33168


Change subject: mediatek/mt8183: modify vproc12 voltage
......................................................................

mediatek/mt8183: modify vproc12 voltage

Modify correct vproc12 register to set processor voltage.

BUG=b:80501386
BRANCH=none
Test=Boots correctly on Kukui

Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Signed-off-by: Hsin-Hsiung Wang <[e-mail]>
---
M src/soc/mediatek/mt8183/mt6358.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/33168/1

diff --git a/src/soc/mediatek/mt8183/mt6358.c b/src/soc/mediatek/mt8183/mt6358.c
index 7054243..1258c3d 100644
--- a/src/soc/mediatek/mt8183/mt6358.c
+++ b/src/soc/mediatek/mt8183/mt6358.c
@@ -496,8 +496,10 @@
 	{0x1B6C, 0x6, 0x6, 0},
 
 	/* Vproc11/Vproc12 to 1.05V */
+	/* [6:0]: RG_BUCK_VPROC11_VOSEL */
 	{0x13a6, 0x58, 0x7F, 0},
-	{0x140a, 0x58, 0x7F, 0},
+	/* [6:0]: RG_BUCK_VPROC12_VOSEL */
+	{0x1426, 0x58, 0x7F, 0},
 };
 
 static struct pmic_setting lp_setting[] = {

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 1
Gerrit-Owner: hsin-hsiung wang <[e-mail]>
Gerrit-MessageType: newchange

[hsin-hsiung wang (Code Review)]

hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33168 )

Change subject: mediatek/mt8183: modify vproc12 voltage
......................................................................


Patch Set 1:

This change is ready for review.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 1
Gerrit-Owner: hsin-hsiung wang <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Roger Lu <[e-mail]>
Gerrit-Reviewer: Tristan Hsieh <[e-mail]>
Gerrit-Reviewer: You-Cheng Syu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: hsin-hsiung wang <[e-mail]>
Gerrit-Comment-Date: Tue, 04 Jun 2019 03:02:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33168 )

Change subject: mediatek/mt8183: modify vproc12 voltage
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/33168/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33168/1//COMMIT_MSG@7 
PS1, Line 7: modify vproc12 voltage
set vproc12 voltage correctly


https://review.coreboot.org/#/c/33168/1//COMMIT_MSG@9 
PS1, Line 9: odify correct vproc12 register to set processor voltage.
Replace with something like this to make it more clear:


The correct address for vproc12 register is 0x1426 instead of 0x140a.



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 1
Gerrit-Owner: hsin-hsiung wang <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Roger Lu <[e-mail]>
Gerrit-Reviewer: Tristan Hsieh <[e-mail]>
Gerrit-Reviewer: You-Cheng Syu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: hsin-hsiung wang <[e-mail]>
Gerrit-Comment-Date: Tue, 04 Jun 2019 03:17:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...coreboot[master]: mediatek/mt8183: set vproc12 voltage correctly

[hsin-hsiung wang (Code Review)]

Hello You-Cheng Syu, Roger Lu, Tristan Hsieh, Hung-Te Lin, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/33168

to look at the new patch set (#2).

Change subject: mediatek/mt8183: set vproc12 voltage correctly
......................................................................

mediatek/mt8183: set vproc12 voltage correctly

The correct address for vproc12 register of sw mode is 0x1426 instead
of 0x140a.

BUG=b:80501386
BRANCH=none
Test=Boots correctly on Kukui

Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Signed-off-by: Hsin-Hsiung Wang <[e-mail]>
---
M src/soc/mediatek/mt8183/mt6358.c
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/33168/2
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 2
Gerrit-Owner: hsin-hsiung wang <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Roger Lu <[e-mail]>
Gerrit-Reviewer: Tristan Hsieh <[e-mail]>
Gerrit-Reviewer: You-Cheng Syu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: hsin-hsiung wang <[e-mail]>
Gerrit-MessageType: newpatchset

Change in ...coreboot[master]: mediatek/mt8183: set vproc12 voltage correctly

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33168 )

Change subject: mediatek/mt8183: set vproc12 voltage correctly
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 2
Gerrit-Owner: hsin-hsiung wang <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Roger Lu <[e-mail]>
Gerrit-Reviewer: Tristan Hsieh <[e-mail]>
Gerrit-Reviewer: You-Cheng Syu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: hsin-hsiung wang <[e-mail]>
Gerrit-Comment-Date: Tue, 04 Jun 2019 03:42:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...coreboot[master]: mediatek/mt8183: set vproc12 voltage correctly

[hsin-hsiung wang (Code Review)]

hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33168 )

Change subject: mediatek/mt8183: set vproc12 voltage correctly
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 2
Gerrit-Owner: hsin-hsiung wang <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Roger Lu <[e-mail]>
Gerrit-Reviewer: Tristan Hsieh <[e-mail]>
Gerrit-Reviewer: You-Cheng Syu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: hsin-hsiung wang <[e-mail]>
Gerrit-Comment-Date: Wed, 05 Jun 2019 06:21:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...coreboot[master]: mediatek/mt8183: set vproc12 voltage correctly

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33168 )

Change subject: mediatek/mt8183: set vproc12 voltage correctly
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33168/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33168/2//COMMIT_MSG@14 
PS2, Line 14: Test=Boots correctly on Kukui
Did it boot before?



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 2
Gerrit-Owner: hsin-hsiung wang <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Roger Lu <[e-mail]>
Gerrit-Reviewer: Tristan Hsieh <[e-mail]>
Gerrit-Reviewer: You-Cheng Syu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: hsin-hsiung wang <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Thu, 06 Jun 2019 09:40:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...coreboot[master]: mediatek/mt8183: set vproc12 voltage correctly

[hsin-hsiung wang (Code Review)]

hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33168 )

Change subject: mediatek/mt8183: set vproc12 voltage correctly
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33168/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33168/2//COMMIT_MSG@14 
PS2, Line 14: Test=Boots correctly on Kukui
> Did it boot before?
> yes, the device can boot successfully with this wrong register.
> However, it leads the dvfs failure about vproc12 with this wrong register.

Change in ...coreboot[master]: mediatek/mt8183: set vproc12 voltage correctly

[hsin-hsiung wang (Code Review)]

hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33168 )

Change subject: mediatek/mt8183: set vproc12 voltage correctly
......................................................................


Patch Set 2:

Hi Sirs,
Any other comment about this patch?
Please let me know, many thanks.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 2
Gerrit-Owner: hsin-hsiung wang <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Roger Lu <[e-mail]>
Gerrit-Reviewer: Tristan Hsieh <[e-mail]>
Gerrit-Reviewer: You-Cheng Syu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: hsin-hsiung wang <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Wed, 12 Jun 2019 11:08:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Change in ...coreboot[master]: mediatek/mt8183: set vproc12 voltage correctly

[Nicolas Boichat (Code Review)]

Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33168 )

Change subject: mediatek/mt8183: set vproc12 voltage correctly
......................................................................


Patch Set 2: Code-Review+1

Yes, I came up with the same fix here: https://review.coreboot.org/c/coreboot/+/33569

Thanks.


-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 2
Gerrit-Owner: hsin-hsiung wang <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Nicolas Boichat <[e-mail]>
Gerrit-Reviewer: Nicolas Boichat <[e-mail]>
Gerrit-Reviewer: Roger Lu <[e-mail]>
Gerrit-Reviewer: Tristan Hsieh <[e-mail]>
Gerrit-Reviewer: You-Cheng Syu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: hsin-hsiung wang <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Comment-Date: Tue, 18 Jun 2019 02:47:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Change in ...coreboot[master]: mediatek/mt8183: set vproc12 voltage correctly

[Nicolas Boichat (Code Review)]

Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33168 )

Change subject: mediatek/mt8183: set vproc12 voltage correctly
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33168/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33168/2//COMMIT_MSG@14 
PS2, Line 14: Test=Boots correctly on Kukui
> yes, the device can boot successfully with this wrong register. […]
> You can add this to TEST line:
>      See that regulator is not stuck to 1.05V anymore:
>      grep vproc12 /sys/kernel/debug/regulator/regulator_summary

Change in ...coreboot[master]: mediatek/mt8183: set vproc12 voltage correctly

[hsin-hsiung wang (Code Review)]

Hello Nicolas Boichat, Nicolas Boichat, You-Cheng Syu, Roger Lu, Tristan Hsieh, Hung-Te Lin, build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/c/coreboot/+/33168

to look at the new patch set (#3).

Change subject: mediatek/mt8183: set vproc12 voltage correctly
......................................................................

mediatek/mt8183: set vproc12 voltage correctly

The correct address for vproc12 register of sw mode is 0x1426 instead
of 0x140a.

BUG=b:80501386
BRANCH=none
Test=Boots correctly on Kukui and see that regulator is not stuck to
1.05V anymore:
grep vproc12 /sys/kernel/debug/regulator/regulator_summary

Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Signed-off-by: Hsin-Hsiung Wang <[e-mail]>
---
M src/soc/mediatek/mt8183/mt6358.c
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/33168/3
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 3
Gerrit-Owner: hsin-hsiung wang <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Nicolas Boichat <[e-mail]>
Gerrit-Reviewer: Nicolas Boichat <[e-mail]>
Gerrit-Reviewer: Roger Lu <[e-mail]>
Gerrit-Reviewer: Tristan Hsieh <[e-mail]>
Gerrit-Reviewer: You-Cheng Syu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: hsin-hsiung wang <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: newpatchset

Change in ...coreboot[master]: mediatek/mt8183: set vproc12 voltage correctly

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33168 )

Change subject: mediatek/mt8183: set vproc12 voltage correctly
......................................................................

mediatek/mt8183: set vproc12 voltage correctly

The correct address for vproc12 register of sw mode is 0x1426 instead
of 0x140a.

BUG=b:80501386
BRANCH=none
Test=Boots correctly on Kukui and see that regulator is not stuck to
1.05V anymore:
grep vproc12 /sys/kernel/debug/regulator/regulator_summary

Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Signed-off-by: Hsin-Hsiung Wang <[e-mail]>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33168
Reviewed-by: Hung-Te Lin <[e-mail]>
Reviewed-by: Nicolas Boichat <[e-mail]>
Tested-by: build bot (Jenkins) <[e-mail]>
---
M src/soc/mediatek/mt8183/mt6358.c
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Nicolas Boichat: Looks good to me, but someone else must approve
  Hung-Te Lin: Looks good to me, approved
  hsin-hsiung wang: Looks good to me, but someone else must approve



diff --git a/src/soc/mediatek/mt8183/mt6358.c b/src/soc/mediatek/mt8183/mt6358.c
index ea4274f..53d2a43 100644
--- a/src/soc/mediatek/mt8183/mt6358.c
+++ b/src/soc/mediatek/mt8183/mt6358.c
@@ -497,8 +497,10 @@
 	{0x1B6C, 0x6, 0x6, 0},
 
 	/* Vproc11/Vproc12 to 1.05V */
+	/* [6:0]: RG_BUCK_VPROC11_VOSEL */
 	{0x13a6, 0x58, 0x7F, 0},
-	{0x140a, 0x58, 0x7F, 0},
+	/* [6:0]: RG_BUCK_VPROC12_VOSEL */
+	{0x1426, 0x58, 0x7F, 0},
 };
 
 static struct pmic_setting lp_setting[] = {

-- 
To view, visit https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 4
Gerrit-Owner: hsin-hsiung wang <[e-mail]>
Gerrit-Reviewer: Hung-Te Lin <[e-mail]>
Gerrit-Reviewer: Nicolas Boichat <[e-mail]>
Gerrit-Reviewer: Nicolas Boichat <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Roger Lu <[e-mail]>
Gerrit-Reviewer: Tristan Hsieh <[e-mail]>
Gerrit-Reviewer: You-Cheng Syu <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Reviewer: hsin-hsiung wang <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: merged