Attention is currently required from: Sunwei Li, Henry Sun, Karthik Ramasubramanian.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56795 )
Change subject: mb/google/dedede/var/cappy2: Add fw_config probe for multi audio codec
......................................................................
Patch Set 8: Code-Review+1
(1 comment)
File src/mainboard/google/dedede/variants/cappy2/gpio.c:
https://review.coreboot.org/c/coreboot/+/56795/comment/66d8e73a_2de9ef36
PS6, Line 25: PAD_NC(GPP_D18, NONE),
The gpio that control the main frequency signal to Realtek
GPP_D18 is configured in baseboard for I2S_MCLK, but cs42l42 not use.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56795
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9121e75eaf46b43e6dc5ef2e31029a153c7a807d
Gerrit-Change-Number: 56795
Gerrit-PatchSet: 8
Gerrit-Owner: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Attention: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 06 Aug 2021 07:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sunwei Li
lisunwei@huaqin.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment