Attention is currently required from: Bao Zheng, Zheng Bao.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69043 )
Change subject: amdfwtool: Add support for 32M image size
......................................................................
Patch Set 3:
(1 comment)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163066):
https://review.coreboot.org/c/coreboot/+/69043/comment/b142140e_1a1b3b64
PS3, Line 2308: case 0xFE020000: /* Fall through */
Prefer 'fallthrough;' over fallthrough comment
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69043
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ica050dfecd258fdd6717c308907d7d4d2e85b926
Gerrit-Change-Number: 69043
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Wed, 09 Nov 2022 05:38:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment