Attention is currently required from: Felix Singer, Nico Huber, Furquan Shaikh, Maxim Polyakov, Angel Pons, Kyösti Mälkki.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57719 )
Change subject: soc/intel/icl: add missing gpio group to fix the group indexes
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/icelake/include/soc/gpio_soc_defs.h:
https://review.coreboot.org/c/coreboot/+/57719/comment/1f6abd55_6a7695dc
PS1, Line 22: #define GROUP_HVCMOS 0xB
No this is not correct. […]
Thanks! Reference code uses 0xf. Will fix this (and probably need to for some other socs, too, now :O)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57719
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7725191173ddc0d43bbe940cdf3b0dc2aa3e5f8d
Gerrit-Change-Number: 57719
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 16 Sep 2021 19:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment