Attention is currently required from: Felix Singer.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80585?usp=email )
Change subject: util: Break up spdx identifier text in scripts & makefiles ......................................................................
Patch Set 2:
(2 comments)
File util/cbfstool/Makefile:
https://review.coreboot.org/c/coreboot/+/80585/comment/c1601a3e_8929d0e8 : PS2, Line 18: SPDX_ID_STRING := SPDX-License-Identifier
Same here.
same reply.
File util/chromeos/update_ec_headers.sh:
https://review.coreboot.org/c/coreboot/+/80585/comment/bea95467_265621b1 : PS2, Line 15: SPDX_ID_STRING="SPDX-License-Identifier"
The variable is only used one time. So it doesn't seem really useful to me. […]
this change is the whole point of the commit. we need to not say "spdx-license-identifier: license". if that string is here, tools can find that string in this file, along with the actual license at the top. it's very confusing to the audit tools.
putting half the string in a variable seemed the cleanstvway to solve the issue, but if you'd have a better way to break up the string, please suggest it.