Attention is currently required from: Reka Norman, Subrata Banik, Balaji Manigandan, Usha P, Tim Wawrzynczak, Patrick Rudolph, Kangheui Won.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59306 )
Change subject: soc/intel/common: Include Alder Lake device IDs
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/59306/comment/73906e9c_ed968629
PS1, Line 30: -N
may be make it as "Alderlake" alone like other does without additional overhead ?
If everything is just going to be "Alderlake", do we even need this table? 😊
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0974fc6ee2ca41d9525cc83155772f111c1fdf86
Gerrit-Change-Number: 59306
Gerrit-PatchSet: 1
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Kangheui Won
khwon@google.com
Gerrit-Comment-Date: Tue, 16 Nov 2021 04:00:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment