Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61307 )
Change subject: console: Add ANSI escape sequences for highlighting ......................................................................
Patch Set 8:
(1 comment)
File src/commonlib/include/commonlib/loglevel.h:
https://review.coreboot.org/c/coreboot/+/61307/comment/a0eca324_05646366 PS8, Line 193: BIOS_EMERG
lol, apparently POST codes are BIOS_EMERG so they blink. […]
Oops, yeah, I agree... uploaded CB:61692.
I was wondering if people would get bothered by the blinking anyway, it is kinda glaring. The other common case that uses BIOS_EMERG is die(), where I guess it is appropriate, but it might still be annoying to have those blink. If people don't like that I'm also fine to just reuse the same formatting for BIOS_ALERT and BIOS_EMERG (the codes above BIOS_ERR are used so rarely anyway that the differentiation isn't very important).