Attention is currently required from: Arthur Heymans.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84059?usp=email )
Change subject: drivers/spi: Stop using a variable-length array ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84059/comment/c7c7fb7b_d5611a1b?usp... : PS1, Line 25: Tested on Asrock B85M Pro4 (Winbond W25Q64FV), MRC cache still works. This will need to be updated
File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/c/coreboot/+/84059/comment/12bfaa35_0ef8ae0a?usp... : PS1, Line 317: chunk_len = MIN(MAX_FLASH_CMD_DATA_SIZE, chunk_len); Not sure about this part, does it truncate the write properly? Should it be an assertion of some kind or a check-and-fail thing? (`if (chunk_len > MAX_FLASH_CMD_DATA_SIZE) return -1;`)