Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34681 )
Change subject: soc/intel/fsp_broadwell_de: Populate SMBIOS tables with memory information
......................................................................
Patch Set 4:
(2 comments)
@Werner: Any objectives against always providing SMBIOS type17 at cost of slightly increased boot time from your side?
https://review.coreboot.org/c/coreboot/+/34681/4/src/soc/intel/fsp_broadwell...
File src/soc/intel/fsp_broadwell_de/Kconfig:
https://review.coreboot.org/c/coreboot/+/34681/4/src/soc/intel/fsp_broadwell...
PS4, Line 96: config SAVE_DRAM_INFO
I don't see why it should be board specific.
https://review.coreboot.org/c/coreboot/+/34681/4/src/soc/intel/fsp_broadwell...
File src/soc/intel/fsp_broadwell_de/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/34681/4/src/soc/intel/fsp_broadwell...
PS4, Line 124: if (CONFIG(SAVE_DRAM_INFO))
!CONFIG(FSP_MEMORY_DOWN)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34681
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1162eb4484dab46f1ab9fe3426eecc4d9378e8e2
Gerrit-Change-Number: 34681
Gerrit-PatchSet: 4
Gerrit-Owner: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Aug 2019 08:45:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment