Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19988 )
Change subject: cpu/amd/car: Fix checkpatch warnings
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/19988/1/src/cpu/amd/car/disable_cache_as_ram...
File src/cpu/amd/car/disable_cache_as_ram.c:
PS1, Line 61: msr.lo &= ~(SYSCFG_MSR_MtrrFixDramEn
: | SYSCFG_MSR_MtrrFixDramModEn);
too bad this doesn't fit in one line
can you align after "=&"?
--
To view, visit
https://review.coreboot.org/19988
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5a5abaa06f8e285ff58436789318cb9cd3b7ac3
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Evelyn Huang
evhuang@google.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Philippe Mathieu-Daudé
philippe.mathieu.daude@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes