Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
mb/google/volteer: add spds for Eldrid
Add DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com Original-Commit-Id: Original-Change-Id: Ia905144349b89a4c402d8ec7a567053716b80274 Original-Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/H5AN8G6NDJR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/H5ANAG6NCMR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/MT40A512M16TB_062E.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc 4 files changed, 103 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/1
diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/H5AN8G6NDJR_XNC.spd.hex b/src/mainboard/google/volteer/variants/eldrid/memory/H5AN8G6NDJR_XNC.spd.hex new file mode 100644 index 0000000..447e198 --- /dev/null +++ b/src/mainboard/google/volteer/variants/eldrid/memory/H5AN8G6NDJR_XNC.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 05 0D F8 FF 02 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 D0 19 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/H5ANAG6NCMR_XNC.spd.hex b/src/mainboard/google/volteer/variants/eldrid/memory/H5ANAG6NCMR_XNC.spd.hex new file mode 100644 index 0000000..7ee0b58 --- /dev/null +++ b/src/mainboard/google/volteer/variants/eldrid/memory/H5ANAG6NCMR_XNC.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 85 21 91 08 00 60 00 03 01 03 00 00 +00 00 05 0D F8 FF 02 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 A8 14 28 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 16 36 +0B 35 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C 00 00 00 00 00 E7 00 C0 6E +0F 01 1F 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/MT40A512M16TB_062E.spd.hex b/src/mainboard/google/volteer/variants/eldrid/memory/MT40A512M16TB_062E.spd.hex new file mode 100644 index 0000000..95aaa4f --- /dev/null +++ b/src/mainboard/google/volteer/variants/eldrid/memory/MT40A512M16TB_062E.spd.hex @@ -0,0 +1,32 @@ +23 11 0C 03 45 21 00 08 00 60 00 03 02 03 00 00 +00 00 05 0D F8 FF 2F 00 6E 6E 6E 11 00 6E F0 0A +20 08 00 05 00 F0 2B 34 28 00 78 00 14 3C 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 16 36 0B 35 +16 36 0B 35 00 00 16 36 0B 35 16 36 0B 35 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 9C B5 00 00 00 00 E7 00 20 4D +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc new file mode 100644 index 0000000..c9c52a4 --- /dev/null +++ b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc @@ -0,0 +1,7 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += H5AN8G6NDJR_XNC.spd.hex # ID = 0(0b0000) +SPD_SOURCES += MT40A512M16TB_062E.spd.hex # ID = 1(0b0001) +SPD_SOURCES += H5ANAG6NCMR_XNC.spd.hex # ID = 2(0b0010)
YH Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
Patch Set 1: Code-Review+1
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#2).
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
mb/google/volteer: add spds for Eldrid
Add three DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com Original-Commit-Id: Original-Change-Id: Ia905144349b89a4c402d8ec7a567053716b80274 Original-Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/H5AN8G6NDJR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/H5ANAG6NCMR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/MT40A512M16TB_062E.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc 4 files changed, 103 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/2
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
Patch Set 1:
Reuploaded patch to force the build bot to try again.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
Patch Set 3:
This change is ready for review.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44272/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44272/4/src/mainboard/google/voltee... PS4, Line 2: auto-generated which script generated this? i wish scripts would leave some sort of signature.
https://review.coreboot.org/c/coreboot/+/44272/4/src/mainboard/google/voltee... PS4, Line 4: src/mainboard/goo i'd suggest $(abspath .) here so we don't hard code the name of the containing directory.
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#5).
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
mb/google/volteer: add spds for Eldrid
Add three DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com Original-Commit-Id: Original-Change-Id: Ia905144349b89a4c402d8ec7a567053716b80274 Original-Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/H5AN8G6NDJR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/H5ANAG6NCMR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/MT40A512M16TB_062E.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc 4 files changed, 104 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/5
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44272/4/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44272/4/src/mainboard/google/voltee... PS4, Line 2: auto-generated
which script generated this? i wish scripts would leave some sort of signature.
Done
https://review.coreboot.org/c/coreboot/+/44272/4/src/mainboard/google/voltee... PS4, Line 4: src/mainboard/goo
i'd suggest […]
Done
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44272/6/src/mainboard/google/voltee... PS6, Line 3: $(abspath .) ugh, i just tried this and it doesn't do what i thought :( all these Makefile.incs get included in the top level makefile so this computes the top level dir.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44272/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44272/4//COMMIT_MSG@7 PS4, Line 7: spds SPDs
https://review.coreboot.org/c/coreboot/+/44272/4//COMMIT_MSG@19 PS4, Line 19: Original-Commit-Id: Remove.
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#7).
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
mb/google/volteer: add spds for Eldrid
Add three DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com Original-Commit-Id: Original-Change-Id: Ia905144349b89a4c402d8ec7a567053716b80274 Original-Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/H5AN8G6NDJR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/H5ANAG6NCMR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/MT40A512M16TB_062E.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc 4 files changed, 104 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/7
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#8).
Change subject: mb/google/volteer: add spds for Eldrid ......................................................................
mb/google/volteer: add spds for Eldrid
Add three DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com Original-Commit-Id: Original-Change-Id: Ia905144349b89a4c402d8ec7a567053716b80274 Original-Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/H5AN8G6NDJR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/H5ANAG6NCMR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/MT40A512M16TB_062E.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc 4 files changed, 104 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/8
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#9).
Change subject: mb/google/volteer: add SPDs for Eldrid ......................................................................
mb/google/volteer: add SPDs for Eldrid
Add three DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/H5AN8G6NDJR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/H5ANAG6NCMR_XNC.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/MT40A512M16TB_062E.spd.hex A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc 4 files changed, 104 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/9
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add SPDs for Eldrid ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44272/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44272/4//COMMIT_MSG@7 PS4, Line 7: spds
SPDs
Done
https://review.coreboot.org/c/coreboot/+/44272/4//COMMIT_MSG@19 PS4, Line 19: Original-Commit-Id:
Remove.
Good catch !
https://review.coreboot.org/c/coreboot/+/44272/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44272/6/src/mainboard/google/voltee... PS6, Line 3: $(abspath .)
ugh, i just tried this and it doesn't do what i thought :( […]
Yes, I noticed that (although it doesn't seem to break in Chromiumos)
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#11).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/11
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 12: Code-Review-2
This will be gone over at least once more to remove any SPD fields that intel MRC does not care about before it is ready for merge.
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#13).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/13
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#15).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/15
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#18).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/18
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#19).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/19
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#20).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
Modify DRAM ID's used to match DRAM IDs eldrid HW is already using.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/20
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#21).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
Modify DRAM ID's used to match DRAM IDs eldrid HW is already using.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/21
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#24).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
Modify DRAM ID's used to match DRAM IDs eldrid HW is already using.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/24
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#25).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/25
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#34).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_parts_manifest.txt 3 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/34
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#37).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_parts_manifest.txt 3 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/37
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#38).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/38
Nick Vaccaro has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Removed Code-Review-2 by Nick Vaccaro nvaccaro@google.com
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 45: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/45/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/44272/45/src/mainboard/google/volte... PS45, Line 2: H5AN8G6NDJR-XNC 0 (0000) : MT40A512M16TB-062E:J 1 (0001) Just a note: If these two parts end up having the same CAS Latencies supported once you hear back from the ODM, then they would basically collapse into a single ID.
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#50).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/50
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 50:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte... PS50, Line 2: H5AN8G6NDJR-XNC 0 (0000) : MT40A512M16TB-062E:J 1 (0001) : H5ANAG6NCMR-XNC 2 (0010) I think this will change based on the latest changes for CAS Latencies.
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#51).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/51
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 51:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte... PS50, Line 2: H5AN8G6NDJR-XNC 0 (0000) : MT40A512M16TB-062E:J 1 (0001) : H5ANAG6NCMR-XNC 2 (0010)
I think this will change based on the latest changes for CAS Latencies.
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 51:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte... PS50, Line 2: H5AN8G6NDJR-XNC 0 (0000) : MT40A512M16TB-062E:J 1 (0001) : H5ANAG6NCMR-XNC 2 (0010)
Done
Didn't the ODM already have a build using IDs 0,1 and 2? Wouldn't it create a problem if the IDs are now changed?
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#55).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/55
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#57).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include three generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
BUG=b:161772961 TEST=none
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 15 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/57
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 58:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte... PS50, Line 2: H5AN8G6NDJR-XNC 0 (0000) : MT40A512M16TB-062E:J 1 (0001) : H5ANAG6NCMR-XNC 2 (0010)
Didn't the ODM already have a build using IDs 0,1 and 2? Wouldn't it create a problem if the IDs are […]
I have addressed/ask that on the bug, but have not heard back yet as to whether they needed specific assignment of DRAM IDs or whether they could go with the ones selected by the tool.
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Mark Hsieh, Rob Barnes, Nick Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#59).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include six generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC - K4A8G165WC-BCWE - K4AAG165WA-BCWE - MT40A1G16KD-062E:E
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
NOTE that Eldrid specified DRAM IDs to be 0 though 5 (i.e. no combined DRAM IDs for parts that use the same SPD).
DRAM IDs for Eldrid: DRAM Part Name ID to assign H5AN8G6NDJR-XNC 0 (0000) MT40A512M16TB-062E:J 1 (0001) H5ANAG6NCMR-XNC 2 (0010) K4A8G165WC-BCWE 3 (0011) K4AAG165WA-BCWE 4 (0100) MT40A1G16KD-062E:E 5 (0101)
BUG=b:161772961 TEST="FW_NAME=eldrid emerge-volteer coreboot" and verify it builds without error.
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 25 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/59
Nick Vaccaro has removed Rob Barnes from this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Removed reviewer Rob Barnes.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 59:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/59/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44272/59/src/mainboard/google/volte... PS59, Line 9: SPD_SOURCES += ddr4-spd-2.hex # ID = 2(0b0010) Parts = H5ANAG6NCMR-XNC NOTE that this SPD has changed based on a recent DDR4 SPD tool fix (https://review.coreboot.org/c/coreboot/+/44870), so you will want to cherry-pick that patch and then cherry-pick this on top of it so that you have the right bits in ddr-spd-2.hex.
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Mark Hsieh, Nick Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#63).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include six generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC - K4A8G165WC-BCWE - K4AAG165WA-BCWE - MT40A1G16KD-062E:E
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
NOTE that Eldrid specified DRAM IDs to be 0 though 5 (i.e. no combined DRAM IDs for parts that use the same SPD).
DRAM IDs for Eldrid: DRAM Part Name ID to assign H5AN8G6NDJR-XNC 0 (0000) MT40A512M16TB-062E:J 1 (0001) H5ANAG6NCMR-XNC 2 (0010) K4A8G165WC-BCWE 3 (0011) K4AAG165WA-BCWE 4 (0100) MT40A1G16KD-062E:E 5 (0101)
BUG=b:161772961 TEST="FW_NAME=eldrid emerge-volteer coreboot" and verify it builds without error.
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/63
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 65: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 66:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt:
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... PS66, Line 4: ,3 : K4AAG165WA-BCWE,4 : MT40A1G16KD-062E:E,5 Why are the rest of the parts assigned fixed IDs? I think only 0,1,2 were used for the previous build?
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 66:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44272/59/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/44272/59/src/mainboard/google/volte... PS59, Line 9: SPD_SOURCES += ddr4-spd-2.hex # ID = 2(0b0010) Parts = H5ANAG6NCMR-XNC
NOTE that this SPD has changed based on a recent DDR4 SPD tool fix (https://review.coreboot. […]
I rebased this patch on top of the others to assure ddr4-spd-2-hex is correct when this CL merges.
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt:
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... PS66, Line 4: ,3 : K4AAG165WA-BCWE,4 : MT40A1G16KD-062E:E,5
Why are the rest of the parts assigned fixed IDs? I think only 0,1,2 were used for the previous buil […]
Because it was requested. Please see bug.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 66:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt:
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... PS66, Line 4: ,3 : K4AAG165WA-BCWE,4 : MT40A1G16KD-062E:E,5
Because it was requested. Please see bug.
These parts are being requested for next build. You can just let the tool assign the IDs for the new parts and let the ODM know what IDs to use. The only reason we have used fixed IDs for parts 0,1,2 is to maintain backward compatibility with last build. Can you please drop the fixed IDs and provide the updated table to ODM to use for the next build.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 66:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt:
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... PS66, Line 4: ,3 : K4AAG165WA-BCWE,4 : MT40A1G16KD-062E:E,5
These parts are being requested for next build. […]
Posted comment on bug too.
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Mark Hsieh, Nick Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#67).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include six generic DDR4 SPDs for the following parts for Eldrid: - H5AN8G6NDJR-XNC - MT40A512M16TB-062E:J - H5ANAG6NCMR-XNC - K4A8G165WC-BCWE - K4AAG165WA-BCWE - MT40A1G16KD-062E:E
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
NOTE that Eldrid specified DRAM IDs to be 0 though 2 (i.e. no combined DRAM IDs for parts that use the same SPD).
DRAM IDs for Eldrid: DRAM Part Name ID to assign H5AN8G6NDJR-XNC 0 (0000) MT40A512M16TB-062E:J 1 (0001) H5ANAG6NCMR-XNC 2 (0010) K4A8G165WC-BCWE 0 (0000) K4AAG165WA-BCWE 3 (0011) MT40A1G16KD-062E:E 3 (0011)
BUG=b:161772961 TEST="FW_NAME=eldrid emerge-volteer coreboot" and verify it builds without error.
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/67
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 67:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt:
https://review.coreboot.org/c/coreboot/+/44272/66/src/mainboard/google/volte... PS66, Line 4: ,3 : K4AAG165WA-BCWE,4 : MT40A1G16KD-062E:E,5
Posted comment on bug too.
They requested specific DRAM IDs when they requested the additional three parts in https://b.corp.google.com/issues/161772961#comment35. I asked if they really needed them or not, but did not get a response back quickly enough, and after re-reading their comments, it seemed clear they were asking for those parts to be assigned specific IDs, so I made the change (I'm OOO for the next 10 days, so was trying to finish this up before I have to leave, so I moved forward without an answer).
They have responded that what I had before making the IDs match their request was sufficient (0-2 specified, the rest chosen by the tool), so I will revert back to that.
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Mark Hsieh, Nick Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#68).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include six generic DDR4 SPDs for the following parts for Eldrid:
DRAM Part Name DRAM ID to assign H5AN8G6NDJR-XNC 0 (0000) MT40A512M16TB-062E:J 1 (0001) H5ANAG6NCMR-XNC 2 (0010) K4A8G165WC-BCWE 0 (0000) K4AAG165WA-BCWE 3 (0011) MT40A1G16KD-062E:E 3 (0011)
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
NOTE that Eldrid specified DRAM IDs to be 0 though 2 (i.e. no combined DRAM IDs for parts that use the same SPD).
BUG=b:161772961 TEST="FW_NAME=eldrid emerge-volteer coreboot" and verify it builds without error.
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/68
Hello build bot (Jenkins), YH Lin, Furquan Shaikh, Patrick Georgi, Martin Roth, Caveh Jalali, Duncan Laurie, Mice Lin, Mark Hsieh, Nick Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44272
to look at the new patch set (#69).
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include six generic DDR4 SPDs for the following parts for Eldrid:
DRAM Part Name DRAM ID to assign H5AN8G6NDJR-XNC 0 (0000) MT40A512M16TB-062E:J 1 (0001) H5ANAG6NCMR-XNC 2 (0010) K4A8G165WC-BCWE 0 (0000) K4AAG165WA-BCWE 3 (0011) MT40A1G16KD-062E:E 3 (0011)
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
NOTE that Eldrid specified DRAM IDs for the first three parts to be 0 though 2 (i.e. no combined DRAM IDs for parts that use the same SPD).
BUG=b:161772961 TEST="FW_NAME=eldrid emerge-volteer coreboot" and verify it builds without error.
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/44272/69
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 69:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44272/45/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/44272/45/src/mainboard/google/volte... PS45, Line 2: H5AN8G6NDJR-XNC 0 (0000) : MT40A512M16TB-062E:J 1 (0001)
Just a note: If these two parts end up having the same CAS Latencies supported once you hear back fr […]
Done
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt:
https://review.coreboot.org/c/coreboot/+/44272/50/src/mainboard/google/volte... PS50, Line 2: H5AN8G6NDJR-XNC 0 (0000) : MT40A512M16TB-062E:J 1 (0001) : H5ANAG6NCMR-XNC 2 (0010)
I have addressed/ask that on the bug, but have not heard back yet as to whether they needed specific […]
Done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 69: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
mb/google/volteer: add generic DDR4 SPDs for Eldrid
Add Makefile.inc to include six generic DDR4 SPDs for the following parts for Eldrid:
DRAM Part Name DRAM ID to assign H5AN8G6NDJR-XNC 0 (0000) MT40A512M16TB-062E:J 1 (0001) H5ANAG6NCMR-XNC 2 (0010) K4A8G165WC-BCWE 0 (0000) K4AAG165WA-BCWE 3 (0011) MT40A1G16KD-062E:E 3 (0011)
Add mem_list_variant.txt as a manifest of eldrid's DRAM parts for use by gen_spd, the generic DD4 SPD generation tool.
Add dram_id_generated.txt to specify DRAM ID strap settings.
NOTE that Eldrid specified DRAM IDs for the first three parts to be 0 though 2 (i.e. no combined DRAM IDs for parts that use the same SPD).
BUG=b:161772961 TEST="FW_NAME=eldrid emerge-volteer coreboot" and verify it builds without error.
Change-Id: Ica62e299ed40e60c2d5928b29ead5d2205b1af66 Signed-off-by: Nick Vaccaro nvaccaro@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44272 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc A src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt 3 files changed, 21 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc new file mode 100644 index 0000000..cfc038e --- /dev/null +++ b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc @@ -0,0 +1,8 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = +SPD_SOURCES += ddr4-spd-1.hex # ID = 0(0b0000) Parts = H5AN8G6NDJR-XNC, K4A8G165WC-BCWE +SPD_SOURCES += ddr4-spd-1.hex # ID = 1(0b0001) Parts = MT40A512M16TB-062E:J +SPD_SOURCES += ddr4-spd-2.hex # ID = 2(0b0010) Parts = H5ANAG6NCMR-XNC +SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = K4AAG165WA-BCWE, MT40A1G16KD-062E:E diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt new file mode 100644 index 0000000..867eca8 --- /dev/null +++ b/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt @@ -0,0 +1,7 @@ +DRAM Part Name ID to assign +H5AN8G6NDJR-XNC 0 (0000) +MT40A512M16TB-062E:J 1 (0001) +H5ANAG6NCMR-XNC 2 (0010) +K4A8G165WC-BCWE 0 (0000) +K4AAG165WA-BCWE 3 (0011) +MT40A1G16KD-062E:E 3 (0011) diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt new file mode 100644 index 0000000..36e0f68 --- /dev/null +++ b/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt @@ -0,0 +1,6 @@ +H5AN8G6NDJR-XNC,0 +MT40A512M16TB-062E:J,1 +H5ANAG6NCMR-XNC,2 +K4A8G165WC-BCWE +K4AAG165WA-BCWE +MT40A1G16KD-062E:E
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44272 )
Change subject: mb/google/volteer: add generic DDR4 SPDs for Eldrid ......................................................................
Patch Set 70:
Automatic boot test returned (PASS/FAIL/TOTAL): 6/1/7 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17209 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17208 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/17207 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17206 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/17205 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17211 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17210
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Caveh Jalali (Code Review)
-
Furquan Shaikh (Code Review)
-
Nick Vaccaro (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
YH Lin (Code Review)