Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table ......................................................................
Patch Set 28:
(6 comments)
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/c7282bd9_37b9b889 PS25, Line 171: }
};
Done
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/12654ebb_3f34749b PS24, Line 159: type_c_port_info_table_entry
`type_c_info` should work?
Done
https://review.coreboot.org/c/coreboot/+/57069/comment/a61bf12b_17acc48f PS24, Line 164: cb_type_c_info
Now that you have implemented the suggestion in https://review.coreboot.org/c/coreboot/+/57069/23.. […]
Done
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/da39ecc0_6f5e1310 PS25, Line 439: u32
uint32_t
Done
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/6c0cea50_87a2e05b PS24, Line 424:
I think you can include coreboot_tables.h directly in chip.h and drop the enum definitions in chip. […]
Done
https://review.coreboot.org/c/coreboot/+/57069/comment/121e20f6_091a92cc PS24, Line 443: struct lb_type_c_info { : uint32_t tag; : uint32_t size; : struct type_c_port_info_table_entry type_c_info; : };
This is what `conn_get_cbmem_buffer()` would look like: […]
Done
-
Nick Vaccaro (Code Review)