Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59381 )
Change subject: amdfwtool: Check duplicated entry ......................................................................
Patch Set 1:
(5 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133575): https://review.coreboot.org/c/coreboot/+/59381/comment/3478ac93_5f6a446e PS1, Line 344: for (entry_i = table; entry_i->type != AMD_FW_INVALID; entry_i ++) space prohibited before that '++' (ctx:WxB)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133575): https://review.coreboot.org/c/coreboot/+/59381/comment/f3c5a2d5_fea78f95 PS1, Line 345: for (entry_j = entry_i + 1; entry_j->type != AMD_FW_INVALID; entry_j ++) space prohibited before that '++' (ctx:WxB)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133575): https://review.coreboot.org/c/coreboot/+/59381/comment/dcf61879_f14a7df6 PS1, Line 359: for (entry_i = table; entry_i->type != AMD_BIOS_INVALID; entry_i ++) space prohibited before that '++' (ctx:WxB)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133575): https://review.coreboot.org/c/coreboot/+/59381/comment/758f80f6_e193e360 PS1, Line 360: for (entry_j = entry_i + 1; entry_j->type != AMD_BIOS_INVALID; entry_j ++) space prohibited before that '++' (ctx:WxB)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133575): https://review.coreboot.org/c/coreboot/+/59381/comment/4d4506bd_df81a373 PS1, Line 364: fprintf(stderr, "duplicated entries:type=%x, inst=%x, subprog=%x\n", line over 96 characters
-
build bot (Jenkins) (Code Review)