Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57463 )
Change subject: mb/google/brya: move MILLIWATTS_TO_WATTS macro in header file ......................................................................
mb/google/brya: move MILLIWATTS_TO_WATTS macro in header file
Move MILLIWATTS_TO_WATTS macro in power_limit header file so all other files can use the same macro.
BUG=None BRANCH=None TEST=Build FW and test on brya0 board
Change-Id: Ic7ecba06b0e0a47546f7307cbfbc3ce0fc634bc3 Signed-off-by: Sumeet Pawnikar sumeet.r.pawnikar@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/57463 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/brya/variants/baseboard/brya/ramstage.c M src/soc/intel/common/block/include/intelblocks/power_limit.h 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/baseboard/brya/ramstage.c b/src/mainboard/google/brya/variants/baseboard/brya/ramstage.c index 1328213..9c2d4aa 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/ramstage.c +++ b/src/mainboard/google/brya/variants/baseboard/brya/ramstage.c @@ -9,8 +9,6 @@ #include <drivers/intel/dptf/chip.h> #include <intelblocks/power_limit.h>
-#define MILLIWATTS_TO_WATTS 1000 - WEAK_DEV_PTR(dptf_policy);
void variant_update_power_limits(const struct cpu_power_limits *limits, size_t num_entries) diff --git a/src/soc/intel/common/block/include/intelblocks/power_limit.h b/src/soc/intel/common/block/include/intelblocks/power_limit.h index 934eaa4..3f18126 100644 --- a/src/soc/intel/common/block/include/intelblocks/power_limit.h +++ b/src/soc/intel/common/block/include/intelblocks/power_limit.h @@ -15,6 +15,8 @@ /* Default power limit value in secs */ #define MOBILE_SKU_PL1_TIME_SEC 28
+#define MILLIWATTS_TO_WATTS 1000 + struct soc_power_limits_config { /* PL1 Override value in Watts */ uint16_t tdp_pl1_override;