Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Balaji Manigandan.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63806 )
Change subject: soc/intel/common: Disable all HECI Interfaces
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63806/comment/293cff1c_d93de40a
PS2, Line 7: soc/intel/common: Disable all HECI Interfaces
commit msg and code changes are not matching
heci_set_to_d0i3 is used to put heci devices into D0i3 prior booting to OS. I don't see where its being disabled in this cl?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63806
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I452512f01ade7668a9ed1aad8666d04ee7672892
Gerrit-Change-Number: 63806
Gerrit-PatchSet: 2
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Sun, 24 Apr 2022 20:04:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment