Attention is currently required from: David Wu, Tim Wawrzynczak, Paul Menzel, Zhuohao Lee, Alan Huang.
Hou-hsun Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58105 )
Change subject: mb/google/brya/var/brask: Configure the ISOLATE pin of LAN
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/variants/brask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/58105/comment/eab9c424_dc4d7516
PS5, Line 86: register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H22)"
Thanks for clarification. I don't have concern for this now. […]
GPP_A7 should be the LAN_WAKE_ODL pin according to https://partnerissuetracker.corp.google.com/issues/204289108#comment23.
GPP_H22 is the ISOLATE pin for RT8125, which relates to the s0ix function.
Is this patch ready to be merged?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58105
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e82dbc1e6c68cbd84b603adc7fdc3ee1d4d3392
Gerrit-Change-Number: 58105
Gerrit-PatchSet: 9
Gerrit-Owner: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hou-hsun Lee
hou-hsun.lee@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 09 Dec 2021 01:40:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Zhuohao Lee
zhuohao@google.com
Comment-In-Reply-To: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-MessageType: comment