Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60209 )
Change subject: soc/amd/common/lpc/espi_util: handle espi_get_configuration error
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/common/block/lpc/espi_util.c:
https://review.coreboot.org/c/coreboot/+/60209/comment/6f3cb23d_d69d290b
PS2, Line 775: espi_get_configuration
IMO, we should...
pushed a new version that adds a return value check. would probably be good to test this on guybrush.
i thought about continuing after a failure instead of returning an error, but when the espi_send_command command fails, there's something seriously wrong and retrying likely won't help, so just returning an error is probably the best thing to do there
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iff1a0670e17b9d6c6f4daf2ea56badf6c428b8c9
Gerrit-Change-Number: 60209
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Tue, 04 Jan 2022 18:22:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment